taffybar: work around repeated arguments bug #41408

puffnfresh · 2018-06-03T09:25:01Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

puffnfresh · 2018-06-03T09:25:14Z

pkgs/development/haskell-modules/configuration-common.nix

+  # Work around large number of repeated arguments
+  # https://github.com/NixOS/nixpkgs/issues/40013
+  taffybar = super.taffybar.overrideDerivation (drv: {
+    strictDeps = true;


@Ericson2314 is this sensible?

peti · 2018-06-03T09:28:21Z

@GrahamcOfBorg build haskell.packages.ghc822.taffybar haskell.packages.ghc843.taffybar

GrahamcOfBorg · 2018-06-03T09:30:42Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-03T10:11:34Z

Failure on x86_64-linux (full log)

Attempted: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/r6sba9zqwp344hlf0y87agqvwzwm81a3-gi-gtk-hs-0.3.6.1/lib
patching script interpreter paths in /nix/store/r6sba9zqwp344hlf0y87agqvwzwm81a3-gi-gtk-hs-0.3.6.1
checking for references to /build in /nix/store/r6sba9zqwp344hlf0y87agqvwzwm81a3-gi-gtk-hs-0.3.6.1...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/4ga474xanbz28gj69jkn0vwkvbn96zhw-gi-gtk-hs-0.3.6.1-doc
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/4ga474xanbz28gj69jkn0vwkvbn96zhw-gi-gtk-hs-0.3.6.1-doc
checking for references to /build in /nix/store/4ga474xanbz28gj69jkn0vwkvbn96zhw-gi-gtk-hs-0.3.6.1-doc...
cannot build derivation '/nix/store/bhibqr8f02blxd0vimkdqrvhnm8n112w-taffybar-2.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4066c7kansf796rv50alv1aq0f82y6mx-taffybar-2.1.0.drv', '/nix/store/bhibqr8f02blxd0vimkdqrvhnm8n112w-taffybar-2.1.0.drv' failed

GrahamcOfBorg · 2018-06-03T12:41:41Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

peti

According to #41408 (comment) taffybar can't be compiled (due to broken dependencies). Did you test this PR?

Ericson2314 · 2018-06-03T16:56:25Z

I opened #41420 to set this in all haskell derivations. I've been meaning to write an RFC to set it everywhere (and thus be able to remove it).

Ericson2314

While I prefer #41420 as a more permanent solution, this is great if that proves too ambitious.

peti

According to #41408 (comment) taffybar can't be compiled (due to broken dependencies). Did you test this PR?

srhb · 2018-06-07T12:24:09Z

Yes, this builds and works on current master (1befcae0dc3130021283aa47616fbb2bb67607e7) with no other changes or overlays.

xeji · 2018-06-17T18:51:09Z

@GrahamcOfBorg build taffybar

GrahamcOfBorg · 2018-06-17T18:52:04Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-17T18:56:04Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-17T19:14:19Z

Success on x86_64-linux (full log)

Attempted: taffybar

Partial log (click to expand)

Warning: haddock-interfaces: /nix/store/j2k151dmalrlybgccjkxw9i63kxxang5-gi-atk-2.0.15/share/doc/x86_64-linux-ghc-8.2.2/gi-atk-2.0.15/html/gi-atk.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/j2k151dmalrlybgccjkxw9i63kxxang5-gi-atk-2.0.15/share/doc/x86_64-linux-ghc-8.2.2/gi-atk-2.0.15/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/9fd03cvs7nbdc8zd77fkiva0nsbjc7nl-gi-gdkx11-3.0.2/share/doc/x86_64-linux-ghc-8.2.2/gi-gdkx11-3.0.2/html/gi-gdkx11.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/9fd03cvs7nbdc8zd77fkiva0nsbjc7nl-gi-gdkx11-3.0.2/share/doc/x86_64-linux-ghc-8.2.2/gi-gdkx11-3.0.2/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/8r3rfyclp2i6w5scfhxblwj6ppkihsxm-gi-gtk-3.0.23/share/doc/x86_64-linux-ghc-8.2.2/gi-gtk-3.0.23/html/gi-gtk.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/8r3rfyclp2i6w5scfhxblwj6ppkihsxm-gi-gtk-3.0.23/share/doc/x86_64-linux-ghc-8.2.2/gi-gtk-3.0.23/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/3cxws1bxj3sm8ma81zyazrr67i9fx37s-gi-dbusmenugtk3-0.4.2/share/doc/x86_64-linux-ghc-8.2.2/gi-dbusmenugtk3-0.4.2/html/gi-dbusmenugtk3.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/3cxws1bxj3sm8ma81zyazrr67i9fx37s-gi-dbusmenugtk3-0.4.2/share/doc/x86_64-linux-ghc-8.2.2/gi-dbusmenugtk3-0.4.2/html doesn't exist or isn't a directory
building '/nix/store/9iwk6cv3279px9nx1yvpp3s1civq8jr1-taffybar-with-packages.drv'...
/nix/store/2ldqdjxv430033dsgq5i293w8njfbqnl-taffybar-with-packages

xeji · 2018-06-17T19:14:57Z

@GrahamcOfBorg build haskell.packages.ghc822.taffybar haskell.packages.ghc843.taffybar

GrahamcOfBorg · 2018-06-17T19:15:36Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-17T19:19:04Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-17T20:02:56Z

Success on x86_64-linux (full log)

Attempted: haskell.packages.ghc822.taffybar, haskell.packages.ghc843.taffybar

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vfqqj3yzmz5x8wm1nnji20j67h2xfa45-taffybar-2.1.2-data
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vfqqj3yzmz5x8wm1nnji20j67h2xfa45-taffybar-2.1.2-data
checking for references to /build in /nix/store/vfqqj3yzmz5x8wm1nnji20j67h2xfa45-taffybar-2.1.2-data...
shrinking RPATHs of ELF executables and libraries in /nix/store/y02c5p9zqhqwvilj0j8l2dg5vdxmfal7-taffybar-2.1.2-doc
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/y02c5p9zqhqwvilj0j8l2dg5vdxmfal7-taffybar-2.1.2-doc
checking for references to /build in /nix/store/y02c5p9zqhqwvilj0j8l2dg5vdxmfal7-taffybar-2.1.2-doc...
/nix/store/8r6cj4v19nyjv98yfhw0vpi0lqcl22px-taffybar-2.1.2
/nix/store/y7asn3p0gs50agkaj3zfwwy5k45193kz-taffybar-2.1.2

xeji · 2018-06-17T20:11:33Z

Seems to build fine.

taffybar: work around repeated arguments bug

9dcf7d0

Fixes NixOS#40013

puffnfresh requested a review from peti as a code owner June 3, 2018 09:25

puffnfresh commented Jun 3, 2018

View reviewed changes

GrahamcOfBorg added the 6.topic: haskell label Jun 3, 2018

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 3, 2018

peti reviewed Jun 3, 2018

View reviewed changes

Ericson2314 approved these changes Jun 3, 2018

View reviewed changes

peti requested changes Jun 4, 2018

View reviewed changes

NixOS deleted a comment from GrahamcOfBorg Jun 4, 2018

xeji merged commit 045686f into NixOS:master Jun 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

taffybar: work around repeated arguments bug #41408

taffybar: work around repeated arguments bug #41408

puffnfresh commented Jun 3, 2018

puffnfresh Jun 3, 2018

Ericson2314 Jun 3, 2018

peti commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

peti left a comment

Ericson2314 commented Jun 3, 2018 •

edited

Ericson2314 left a comment

peti left a comment

srhb commented Jun 7, 2018

xeji commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

xeji commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

xeji commented Jun 17, 2018

taffybar: work around repeated arguments bug #41408

taffybar: work around repeated arguments bug #41408

Conversation

puffnfresh commented Jun 3, 2018

Motivation for this change

Things done

puffnfresh Jun 3, 2018

Choose a reason for hiding this comment

Ericson2314 Jun 3, 2018

Choose a reason for hiding this comment

peti commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

GrahamcOfBorg commented Jun 3, 2018

peti left a comment

Choose a reason for hiding this comment

Ericson2314 commented Jun 3, 2018 • edited

Ericson2314 left a comment

Choose a reason for hiding this comment

peti left a comment

Choose a reason for hiding this comment

srhb commented Jun 7, 2018

xeji commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

xeji commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

GrahamcOfBorg commented Jun 17, 2018

xeji commented Jun 17, 2018

Ericson2314 commented Jun 3, 2018 •

edited