New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHCJS 8.4/8.2 in sandboxed builds #41411
Conversation
de9024d
to
3260d95
Compare
@GrahamcOfBorg build haskell.compiler.ghcjs |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
Huh. I could have swore that cabal.config thing was going to work. Hadn't tested it because ghc842 doesn't seem to be cached. I'll go back to just having gcc in the build rather than abusing the config file until a better solution presents itself |
3260d95
to
5603705
Compare
There, that should fix darwin (again, untested since ghc842 is not cached) |
@GrahamcOfBorg build haskell.compiler.ghcjs |
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: haskell.compiler.ghcjs Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: haskell.compiler.ghcjs Partial log (click to expand)
|
gcc needs to be added as an argument again... |
Failure on x86_64-linux (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs Partial log (click to expand)
|
5603705
to
a00f129
Compare
Crap, sorry. Should work now. |
@GrahamcOfBorg build haskell.compiler.ghcjs |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
I understand the timeout on darwin, but the x86_64-linux failure looks like a bug. |
a00f129
to
5b73c93
Compare
Huh. The libexec dir got changed on me. Fixed now. |
@GrahamcOfBorg build haskell.compiler.ghcjs |
Success on x86_64-linux (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: haskell.compiler.ghcjs Partial log (click to expand)
|
Can't do much about the timeout, so let's merge and watch it on Hydra. |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs Partial log (click to expand)
|
* master: (26 commits) python.pkgs.cairocffi: update tests for Cairo 1.15.12 python.pkgs.cairocffi: 0.8.0 -> 0.8.1 freecell-solver: fix build perlPackages.CPANPLUS: restore build inputs removed in #41394 Fix GHCJS 8.4/8.2 in sandboxed builds (#41411) dockerTools.pullImage: expose image* attributes (#41366) rust: disable tests on darwin python.pkgs.detox: 0.11 -> 0.12 certbot: disable check on darwin freeimage: fix build with glibc 2.27 shadowsocks-libev: supports darwin (#41421) pythonPackages.jira: fix build (#41419) SDL: propagate libiconv schema2ldif: Init at 1.3 nixos/exim: Add unit restart trigger (#41418) Add myself as maintainer for dnsdist Add myself as maintainer synapse-bt: init at 2018-06-04 (#41402) skim: 0.3.2 -> 0.4.0 (#41417) ctags: fix source url (#41382) ...
Motivation for this change
cabal
previously tried to contact hackage.haskell.org, which it definitely does not need to do. Instead we create a nearly empty.cabal/config
file.As a side benefit, we also get to fix cabal looking for
gcc
when it should be using$CC
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)