New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcs3: 0.0.4-8032 -> 0.0.5-6980 #41414
Conversation
cc @abbradar |
@GrahamcOfBorg build rpcs3 |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3 Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3 Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: rpcs3 Partial log (click to expand)
|
Build fails with hash mismatch. |
Manually write version header instead of generating it with git, which required leaveDotGit to be enabled. This caused some hash mismatches (see NixOS#8567) has thus been disabled.
@xeji Should be fixed now. |
@GrahamcOfBorg build rpcs3 |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3 Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: rpcs3 Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3 Partial log (click to expand)
|
Still doesn't build. |
@xeji Yes, but it seems to be related to the update of the git package instead of the hash mismatch error when leaving leaveDotGit enabled. |
The bash script seems to be failing at
The name and dir variable are set to empty strings, causing the script to execute git config --get .url which fails.
|
Maybe @dtzWill can have a look. I've seen the same error in another PR today (unfortunately don't remember which one). |
@GrahamcOfBorg build rpcs3 |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3 Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: rpcs3 Partial log (click to expand)
|
Motivation for this change
Enable leaveDotGit to report correct version info (branch name and commit count). Let me know if this causes some problems (seefetchgit
withleaveDotGit = true
is still not completely deterministic #8567).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)