Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcs3: 0.0.4-8032 -> 0.0.5-6980 #41414

Merged
merged 5 commits into from Jun 25, 2018
Merged

rpcs3: 0.0.4-8032 -> 0.0.5-6980 #41414

merged 5 commits into from Jun 25, 2018

Conversation

ilian
Copy link
Member

@ilian ilian commented Jun 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 3, 2018

cc @abbradar

@ilian ilian changed the title rpcs3: 0.0.4-8032 -> 0.0.5-6884 rpcs3: 0.0.4-8032 -> 0.0.5-6925 Jun 9, 2018
@ilian ilian changed the title rpcs3: 0.0.4-8032 -> 0.0.5-6925 rpcs3: 0.0.4-8032 -> 0.0.5-6938 Jun 12, 2018
@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

@GrahamcOfBorg build rpcs3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: rpcs3

Partial log (click to expand)

Deleted remote-tracking branch origin/release_39 (was a093ef43dd5).
Deleted remote-tracking branch origin/release_40 (was c8fccc53ed6).
Deleted remote-tracking branch origin/release_50 (was 1368f4044e6).
Deleted remote-tracking branch origin/release_60 (was e9b8c0e3cd6).
Deleted remote-tracking branch origin/stable (was 2dfb4034816).
Deleted remote-tracking branch origin/testing (was d5c2cca7246).
Deleted tag 'continuous-linux-release_60' (was e9b8c0e3cd6)
fixed-output derivation produced path '/nix/store/23zq8m0ald7g6rj95a909xpq5ybl7qrf-rpcs3-4db0cf0' with sha256 hash '0bjlrm2ka6njydvf0yk6n10hphbrqy1kr0syy0y388qj923n8lsb' instead of the expected hash '1hcafhlz6y1hkbfklszf4hbdiciwgswkwwdpw9j3kvyvgs2bwhfl'
cannot build derivation '/nix/store/2jj6hk46akfnbycmdhinf2p9w7l9rx51-rpcs3-0.0.5-6938.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2jj6hk46akfnbycmdhinf2p9w7l9rx51-rpcs3-0.0.5-6938.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

Build fails with hash mismatch.

Manually write version header instead of generating it with git, which required leaveDotGit to be enabled.
This caused some hash mismatches (see NixOS#8567) has thus been disabled.
@ilian ilian changed the title rpcs3: 0.0.4-8032 -> 0.0.5-6938 rpcs3: 0.0.4-8032 -> 0.0.5-6980 Jun 22, 2018
@ilian
Copy link
Member Author

ilian commented Jun 22, 2018

@xeji Should be fixed now.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build rpcs3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: rpcs3

Partial log (click to expand)

Submodule 'Vulkan/glslang' (https://github.com/KhronosGroup/glslang.git) registered for path 'Vulkan/glslang'
Submodule 'asmjit' (https://github.com/kobalicek/asmjit) registered for path 'asmjit'
Submodule 'llvm' (https://github.com/RPCS3/llvm) registered for path 'llvm'
error: key does not contain a section: .url
builder for '/nix/store/1qqqphkym0ld75ndbnl299wfqx428lx5-rpcs3-81e5f3b.drv' failed with exit code 1
copying path '/nix/store/465dz0hdxvcr19b1nhgagqpdzv6xm90c-ffmpeg-3.4.2' from 'https://cache.nixos.org'...
copying path '/nix/store/mdrf80cpdl2l1a7lqykz7x6hgbm8s9m0-ffmpeg-3.4.2-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/qjlrl3lsxjn9gnyl8f9i1ka8mv3pavnw-ffmpeg-3.4.2-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/3wpc56sprf4ycqys7qxr2k84jil3yda2-rpcs3-0.0.5-6980-81e5f3b7f.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3wpc56sprf4ycqys7qxr2k84jil3yda2-rpcs3-0.0.5-6980-81e5f3b7f.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@ilian
Copy link
Member Author

ilian commented Jun 24, 2018

Build fails since 2624f90 with

error: key does not contain a section: .url

The error does not occur when building on top of its parent commit 37aab4c

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Still doesn't build.

@ilian
Copy link
Member Author

ilian commented Jun 24, 2018

@xeji Yes, but it seems to be related to the update of the git package instead of the hash mismatch error when leaving leaveDotGit enabled.
The new git version might be breaking the nix-prefetch-git script.

@xeji xeji mentioned this pull request Jun 24, 2018
9 tasks
@ilian
Copy link
Member Author

ilian commented Jun 24, 2018

The bash script seems to be failing at

url=$(git config --get "${name}.url")

The name and dir variable are set to empty strings, causing the script to execute
git config --get .url which fails.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Maybe @dtzWill can have a look. I've seen the same error in another PR today (unfortunately don't remember which one).

@dtzWill
Copy link
Member

dtzWill commented Jun 25, 2018

I'd love to take a look, but can't tackle this right now. Reverted the git update for now, hopefully this'll be addressed soon. Sorry for the trouble! :)

(And thanks @xeji and @nocent for identifying the issue and pinging me about it!)

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@GrahamcOfBorg build rpcs3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rpcs3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rpcs3

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f
shrinking /nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f/bin/rpcs3
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f/bin
patching script interpreter paths in /nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f
checking for references to /build in /nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f...
postPatchMkspecs
postPatchMkspecs
/nix/store/4c9gfadv1zsxpbi8ifx6rsy6z31mnw9w-rpcs3-0.0.5-6980-81e5f3b7f

@xeji xeji merged commit f8530c8 into NixOS:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants