nixos/luksroot: Support keyfile offsets #41425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-d
reviewed
Jun 4, 2018
| example = 4096; | ||
| type = types.nullOr types.int; | ||
| description = '' | ||
| The offset of the key file. Use this in combination with |
There was a problem hiding this comment.
Minor nitpicks, but:
- You've got an extra space after "Use this"
- "use part of a file as key" - do you mean "as the key"?
- "is used as key file" - you may mean "used as a key file"?
There was a problem hiding this comment.
I fixed what I think was wrong. "as the key" would be wrong because it's not actually used as key, but as key file. I hope you are happy with the changed version
|
@andrew-d Fixed and rebased |
|
Can you squash both commits into 1? |
|
@infinisil Squashed and rebased to master |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to use a raw partition as keyfile for multiple disks, so I need to offset each key from the previous one.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)