pythonPackages.jira: fix build #41419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python36Packages.jira |
|
Success on x86_64-linux (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
xeji
reviewed
Jun 3, 2018
| @@ -12,7 +14,7 @@ buildPythonPackage rec { | |||
| }; | |||
|
|
|||
| buildInputs = [ glibcLocales pytest pytestcov pytestrunner pbr ]; | |||
| propagatedBuildInputs = [ requests requests_oauthlib requests_toolbelt defusedxml ]; | |||
| propagatedBuildInputs = [ requests requests_oauthlib requests_toolbelt defusedxml sphinx pbr ]; | |||
There was a problem hiding this comment.
Are sphinx and pbr really needed at runtime? If they're used only for building, why propagate them?
|
Success on x86_64-darwin (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
|
@xeji without Regarding |
|
Thanks.
Good idea. |
|
@xeji you were right, it's indeed possible to drop |
|
Thanks, sounds good. |
xeji
reviewed
Jun 3, 2018
| @@ -1,29 +1,35 @@ | |||
| { lib, buildPythonPackage, fetchPypi, isPy3k | |||
| , pytest, pytestrunner, pbr, glibcLocales , pytestcov | |||
| , requests, requests_oauthlib, requests_toolbelt, defusedxml }: | |||
| , requests, requests_oauthlib, requests_toolbelt, defusedxml | |||
| , flaky, ipython | |||
There was a problem hiding this comment.
I don't see where flaky is used below.
There was a problem hiding this comment.
ahh dammit, this was part of the attempt to get the test suite running 😅
There was a problem hiding this comment.
... it's a lot easier to find this stuff in other people's code than in your own 😄
The build for `pythonPackages.jira` failed with the following error: ``` Download error on https://pypi.python.org/simple/sphinx/: [Errno -2] Name or service not known -- Some packages may not be found! Couldn't find index page for 'sphinx' (maybe misspelled?) Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found! No local packages or working download links found for sphinx>=1.6.5 Traceback (most recent call last): ... File "/nix/store/bp4dillg6xxblpf00v8d9nxfx3bnggfy-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 667, in easy_install raise DistutilsError(msg) distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('sphinx>=1.6.5') builder for '/nix/store/8dv7mpspyk6kxwnzqb43rzm4q5j14xp0-python3.6-jira-1.0.15.drv' failed with exit code 1 ``` The root issue is most likely caused by some docs fixes upstream (pycontribs/jira@519183d) which were released in 1.0.15. The bump (without the fix) has been performed in 7a6bf66. Since `sphinx` isn't needed during runtime, it's not necessary to use it as `propagatedBuildInput`. In order to work around this the dependency had to be removed from from `setup.py`. See https://hydra.nixos.org/build/75004048 for further reference
|
@GrahamcOfBorg build python36Packages.jira |
|
Success on x86_64-linux (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python36Packages.jira Partial log (click to expand)
|
|
thx for your support! :) |
orivej
added a commit
that referenced
this pull request
Jun 4, 2018
* master: (26 commits) python.pkgs.cairocffi: update tests for Cairo 1.15.12 python.pkgs.cairocffi: 0.8.0 -> 0.8.1 freecell-solver: fix build perlPackages.CPANPLUS: restore build inputs removed in #41394 Fix GHCJS 8.4/8.2 in sandboxed builds (#41411) dockerTools.pullImage: expose image* attributes (#41366) rust: disable tests on darwin python.pkgs.detox: 0.11 -> 0.12 certbot: disable check on darwin freeimage: fix build with glibc 2.27 shadowsocks-libev: supports darwin (#41421) pythonPackages.jira: fix build (#41419) SDL: propagate libiconv schema2ldif: Init at 1.3 nixos/exim: Add unit restart trigger (#41418) Add myself as maintainer for dnsdist Add myself as maintainer synapse-bt: init at 2018-06-04 (#41402) skim: 0.3.2 -> 0.4.0 (#41417) ctags: fix source url (#41382) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The build for
pythonPackages.jirafailed with the following error:The root issue is most likely caused by some docs fixes upstream
(pycontribs/jira@519183d)
which were released in 1.0.15. The bump (without the fix) has been
performed in 7a6bf66.
See https://hydra.nixos.org/build/75004048 for further reference
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)