Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd: 6.0.2p1 -> 6.0.3p1 #41434

Merged
merged 1 commit into from Jun 7, 2018
Merged

opensmtpd: 6.0.2p1 -> 6.0.3p1 #41434

merged 1 commit into from Jun 7, 2018

Conversation

obadz
Copy link
Contributor

@obadz obadz commented Jun 3, 2018

Motivation for this change

No security updates that I can see in change log: https://www.opensmtpd.org/announces/release-6.0.3.txt.

This release introduces 'configurable sub-address delimiters' (which we had on Nix via a compile-time argument that has now been deprecated).

There's also a mention in the changelog: 'unplug filter code from the smtp engine'. Indeed, the patch that we use to specific PATH_LIBEXEC at runtime had a part for taking care of filters and that part seem to no longer correspond to anything in the code, so I've removed it from the patch.

I've also freshened up the rest of the patch file.

It'd be great if someone who runs an opensmtpd service could test this.

cc @joachifm @romildo @dtzWill @rickynils

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: opensmtpd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opensmtpd

Partial log (click to expand)

shrinking /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/sbin/smtpd
shrinking /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/sbin/smtpctl
shrinking /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/libexec/opensmtpd/mail.local
shrinking /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/libexec/opensmtpd/encrypt
gzipping man pages under /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/libexec  /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/bin  /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/sbin
patching script interpreter paths in /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1
checking for references to /build in /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1...
moving /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/sbin/* to /nix/store/d81wr7hqg2zw150fj02k41d2mwilsxcx-opensmtpd-6.0.3p1/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opensmtpd

Partial log (click to expand)

shrinking /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/libexec/opensmtpd/mail.local
shrinking /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/sbin/smtpctl
shrinking /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/sbin/smtpd
gzipping man pages under /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/libexec  /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/bin  /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/sbin
patching script interpreter paths in /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1
checking for references to /build in /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1...
moving /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/sbin/* to /nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1/bin
/nix/store/n222rgf0zh28zams86pwlrhvy13n3cxw-opensmtpd-6.0.3p1

@obadz obadz merged commit 6081f51 into NixOS:master Jun 7, 2018
@obadz
Copy link
Contributor Author

obadz commented Jun 7, 2018

Tested & worked fine.

@obadz obadz deleted the opensmptd-6.0.3p1 branch December 24, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@obadz @GrahamcOfBorg