Add missing gohai derivation and fix dd-agent service unit #41015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project does not have a default versioning scheme. go2nix suggests using the date of the most recent change.
The Datadog agent requires `gohai` to be available on its `$PATH` in order to collect certain metrics. It would previously start up and collect certain types of metrics, but log errors related to the missing gohai binary. This commit configures the systemd-unit to make gohai available at runtime. This fixes NixOS#39810.
|
I suppose this should be backported? cc @domenkozar |
|
@Mic92 If we're talking backports, there's technically a second issue with the dd-agent at the moment. The version of I'll take a look at bumping the agent version but from a cursory glance it seems to be more involved than simply upping the version and updating the source. Should probably also file an issue for it ... edit: issue already exists, #40103 |
|
Can this also be merged into 18.03 (since the module in stable is broken in various ways anyway)? |
|
Is the Problem regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This change adds the gohai package by DataDog, which is required for the existing
dd-agentpackage to function correctly.The issue tracking this problem is #39810
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)