Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openbox: fix wrapping of openbox-xdg-autostart #41006

Merged
merged 1 commit into from Jun 7, 2018
Merged

openbox: fix wrapping of openbox-xdg-autostart #41006

merged 1 commit into from Jun 7, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 24, 2018

Motivation for this change

openbox-xdg-autostart is a Python script that was not being correctly wrapped.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openbox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openbox

Partial log (click to expand)

gzipping man pages under /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/lib  /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/libexec  /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/bin
patching script interpreter paths in /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1
/nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/libexec/openbox-autostart: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/bin/.openbox-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/bin/.openbox-kde-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1/bin/.openbox-gnome-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1...
/nix/store/65yp4qnlrmi41kxk77yhwid9p8fjlsaj-openbox-3.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openbox

Partial log (click to expand)

gzipping man pages under /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/lib  /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/libexec  /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/bin
patching script interpreter paths in /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1
/nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/libexec/openbox-autostart: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/bin/.openbox-kde-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/bin/.openbox-gnome-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1/bin/.openbox-session-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1...
/nix/store/qfy4l6mpm2kiixrgrp0bfp0l6sam86nj-openbox-3.6.1

@matthewbauer matthewbauer merged commit 80046cc into NixOS:master Jun 7, 2018
@romildo romildo deleted the fix.openbox branch June 7, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @GrahamcOfBorg @matthewbauer