Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/borgbackup: make extraArgs a shell variable #41013

Merged
merged 1 commit into from May 24, 2018
Merged

nixos/borgbackup: make extraArgs a shell variable #41013

merged 1 commit into from May 24, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 24, 2018 •
edited

Motivation for this change

in line with the other extra*Args variables

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @globin @ciil

nixos/borgbackup: make extraArgs a shell variable
54f4e42 
in line with the other extra*Args variables
@globin globin merged commit 3c0daa1 into NixOS:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@ciil ciil ciil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @Mic92 @ciil @globin @GrahamcOfBorg