Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: 0.13.68 -> 0.13.69 #41004

Merged
merged 1 commit into from May 24, 2018
Merged

zziplib: 0.13.68 -> 0.13.69 #41004

merged 1 commit into from May 24, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 23, 2018

Backport of 3f36f60 (bump to 0.13.69) from master to address gdraheim/zziplib#27, maybe part of CVE-2018-6869 and CVE-2018-6484.

Motivation for this change

This possible CVE fix is not yet in release-18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
zziplib: 0.13.68 -> 0.13.69
e6d143c 
Semi-automatic update generated by https://github.com/ryantm/nix-update tools.

This update was made based on information from https://repology.org/metapackage/zziplib/versions.

These checks were done:

- built on NixOS
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat -h` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzdir --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzdir --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat -h` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir -h` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy -h` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip -v` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix -v` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem -v` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big -v` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big --version` and found version 0.13.69
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem -h` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem --help` got 0 exit code
- ran `/nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem --version` and found version 0.13.69
- found 0.13.69 with grep in /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69
- directory tree listing: https://gist.github.com/fec112f9114c98b118a59917224af5ff

(cherry picked from commit 3f36f60)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zziplib

Partial log (click to expand)

shrinking /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/bin/unzip-mem
shrinking /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
shrinking /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
shrinking /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
gzipping man pages under /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/lib  /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69
checking for references to /build in /nix/store/jpf85al23p8zrqqp65cim4h7q4m6c7vc-zziplib-0.13.69...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: zziplib

Partial log (click to expand)

make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin17.3.0'
make[2]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin17.3.0'
make[1]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin17.3.0'
post-installation fixup
gzipping man pages under /nix/store/wsd7s8mmpb2qd7yrm6ma7299aszljrlq-zziplib-0.13.69/share/man/
strip is /nix/store/8v9y23q86l8y6kip8110m0d3343ar3al-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wsd7s8mmpb2qd7yrm6ma7299aszljrlq-zziplib-0.13.69/lib  /nix/store/wsd7s8mmpb2qd7yrm6ma7299aszljrlq-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/wsd7s8mmpb2qd7yrm6ma7299aszljrlq-zziplib-0.13.69

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zziplib

Partial log (click to expand)

shrinking /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
shrinking /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
shrinking /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
gzipping man pages under /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/lib  /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69
checking for references to /build in /nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69...
/nix/store/a3b5apx4zgxa4bhbd3bjrx2a832mcxc2-zziplib-0.13.69

@andir andir merged commit 87e30d3 into NixOS:release-18.03 May 24, 2018
@flokli flokli deleted the 18.03-zziplib-0.13.69 branch May 29, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @andir