Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos mysql: make start-up more robust #41010

Merged
merged 1 commit into from May 24, 2018
Merged

nixos mysql: make start-up more robust #41010

merged 1 commit into from May 24, 2018

Conversation

peterhoeg
Copy link
Member

  1. Change start-type to notify when running MariaDB so that we don't have to busy-wait for the
    socket to appear.

  2. Do not manually create the directory under /run as we can get systemd to do
    that for us. This opens up the possibility later for not having to launch as root.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
nixos mysql: make start-up more robust
657bd2a 
1) Change start-type to ```notify``` when running MariaDB so that we don't have to busy-wait for the
socket to appear.

2) Do not manually create the directory under /run as we can get systemd to do
that for us. This opens up the possibility later for not having to launch as root.
@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg test mysql

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.mysql

Partial log (click to expand)

master: exit status 1
syncing
master: running command: sync
master: exit status 0
test script finished in 18.77s
cleaning up
killing master (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/90j65h6lvn2vp8qwhx0f3x3l6vswcfys-vm-test-run-mysql

@xeji xeji merged commit 5b468ea into NixOS:master May 24, 2018
@peterhoeg peterhoeg deleted the f/mysql branch May 24, 2018 15:01
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.mysql

Partial log (click to expand)

master: exit status 1
syncing
master: running command: sync
master: exit status 0
test script finished in 24.79s
cleaning up
killing master (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/xgwjl0jg1yyyz1ypfjv3nslx1y1xnyxh-vm-test-run-mysql

@peterhoeg peterhoeg restored the f/mysql branch May 25, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @xeji @GrahamcOfBorg