Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8] fix: connect the --bind-address arg to the cfg.apiserver.address option #41018

Merged
merged 1 commit into from
May 28, 2018
Merged

[k8] fix: connect the --bind-address arg to the cfg.apiserver.address option #41018

merged 1 commit into from
May 28, 2018
+1 −1

Conversation

ghuntley
Copy link
Member

Motivation for this change

K8 API server always binds to 0.0.0.0 and the cfg.apiserver.address option isn't used

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ghuntley
fix: connect the --bind-address arg to the cfg.apiserver.address option

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan
GPG key ID: 69AC5BC354C89BE6
Verified
Learn about vigilant mode
e3abb43
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 24, 2018
@globin globin merged commit f607f01 into NixOS:master May 28, 2018
@johanot johanot mentioned this pull request Jun 12, 2018
Merged
8 tasks
@ghuntley ghuntley deleted the patch-1 branch August 8, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghuntley @globin @GrahamcOfBorg