Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dozenal: init at version v12010904 #41989

Merged
merged 2 commits into from Aug 20, 2018
Merged

dozenal: init at version v12010904 #41989

merged 2 commits into from Aug 20, 2018

Conversation

CharlesHD
Copy link
Contributor

Motivation for this change

dozenal is a toolsuite for working with base twelve instead of base ten that I use on a daily basis.

hdate is a library for working with hebraic date, I do not use it but dozenal depends on hdate, so I added an hdate derivation too. The hdate utilities works too, maybe it can be useful to others.

Things done
  • Added a hdate derivation, which is a dozenal depency
  • Added the dozenal derivation
  • Added myself in the list of maintainers
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@CharlesHD CharlesHD changed the title Add a dozenal derivation with its dependence hdate dozenal: init at version v12010904 Jun 14, 2018
@CharlesHD
Copy link
Contributor Author

@GrahamcOfBorg build hdate dozenal

joachifm
joachifm reviewed Aug 19, 2018
View reviewed changes
pkgs/applications/misc/dozenal/default.nix Outdated

stdenv.mkDerivation rec {
name = "dozenal";
version = "v12010904";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that version should be a part of name and should not contain the v prefix. You can check builtins.parseDrvName to see how version strings are parsed out of the derivation name.

@joachifm
Copy link
Contributor

Needs a rebase

@CharlesHD
Copy link
Contributor Author

@joachifm thanks for your review. I think I took care of what you pointed out.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build hdate dozenal

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: hdate, dozenal

Partial log (click to expand)

         ^~~~~~~~~
1 warning and 1 error generated.
make[2]: *** [Makefile:409: hdate.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-hdate-1.6.02.drv-0/libhdate-1.6.02/examples/hcal'
make[1]: *** [Makefile:321: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-hdate-1.6.02.drv-0/libhdate-1.6.02/examples'
make: *** [Makefile:440: all-recursive] Error 1
builder for '/nix/store/369waqdi6xwqcfxsp04mj0lsls9sl8kq-hdate-1.6.02.drv' failed with exit code 2
cannot build derivation '/nix/store/6clb12aamszy6v4d3pgr6za88prpz2lj-dozenal-12010904.drv': 1 dependencies couldn't be built
error: build of '/nix/store/369waqdi6xwqcfxsp04mj0lsls9sl8kq-hdate-1.6.02.drv', '/nix/store/6clb12aamszy6v4d3pgr6za88prpz2lj-dozenal-12010904.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hdate, dozenal

Partial log (click to expand)

shrinking /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904/bin/dozstring
shrinking /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904/bin/dozword
shrinking /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904/bin/tgmconv
gzipping man pages under /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904/bin
patching script interpreter paths in /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904
checking for references to /build in /nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904...
/nix/store/pvgqy8pn41nkwfnrzqrlaaqj0pwmmahh-hdate-1.6.02
/nix/store/nw2rdxgqys2dqr65lfpnaabyr7mxqww2-dozenal-12010904

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hdate, dozenal

Partial log (click to expand)

shrinking /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904/bin/tgmconv
shrinking /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904/bin/dozdc
shrinking /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904/bin/dec
gzipping man pages under /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904/bin
patching script interpreter paths in /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904
checking for references to /build in /nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904...
/nix/store/cyc48wn542i76rm3vblli57zhn667kdm-hdate-1.6.02
/nix/store/sisv8nh7vrw8lvp2if6v7p7hgzpjcxam-dozenal-12010904

@joachifm joachifm merged commit 203cd95 into NixOS:master Aug 20, 2018
@CharlesHD CharlesHD deleted the submit/dozenal branch August 21, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CharlesHD @joachifm @GrahamcOfBorg @Janik-Haag