Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ansiconv: init at 1.0.0 #41681

Merged
merged 1 commit into from Jun 10, 2018
Merged

pythonPackages.ansiconv: init at 1.0.0 #41681

merged 1 commit into from Jun 10, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner June 8, 2018 11:30
@ryantm
Copy link
Member

ryantm commented Jun 9, 2018

Looks good to me. It's also available on pypi https://pypi.org/project/ansiconv/#files I'm not sure what source is preferred.

@ryantm
Copy link
Member

ryantm commented Jun 9, 2018

@GrahamcOfBorg build python2.pkgs.ansiconv python3.pkgs.ansiconv

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.ansiconv, python3.pkgs.ansiconv

Partial log (click to expand)

============================= test session starts ==============================
platform darwin -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python3.6-ansiconv-1.0.0.drv-0/source, inifile:
collected 11 items

test/test_ansiconv.py ...........                                        [100%]

========================== 11 passed in 0.03 seconds ===========================
/nix/store/xhyfpfdjrshlv7xk7fbdccrixqykmcff-python2.7-ansiconv-1.0.0
/nix/store/5asi1fgmc2ijzz544myih7qjxgs3fhqs-python3.6-ansiconv-1.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.ansiconv, python3.pkgs.ansiconv

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 11 items

test/test_ansiconv.py ...........                                        [100%]

========================== 11 passed in 0.02 seconds ===========================
/nix/store/bz721bml7gmylj8kyq46zjs7dl099i2x-python2.7-ansiconv-1.0.0
/nix/store/vbg6ya4xsfhx89h3jnjdsrxbg16z4sjc-python3.6-ansiconv-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.ansiconv, python3.pkgs.ansiconv

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 11 items

test/test_ansiconv.py ...........                                        [100%]

========================== 11 passed in 0.16 seconds ===========================
/nix/store/zd55xvsaxcvyqbkav10kyzns2qnwm84d-python2.7-ansiconv-1.0.0
/nix/store/15xl5z7lw85lm2aixig8425nrbfhniln-python3.6-ansiconv-1.0.0

@FRidh FRidh merged commit 1fdc5a9 into NixOS:master Jun 10, 2018
@PsyanticY PsyanticY deleted the ansicov branch June 11, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @ryantm @GrahamcOfBorg @FRidh