Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwm-status: init at 0.4.0 #41726

Merged
merged 1 commit into from Jun 10, 2018
Merged

dwm-status: init at 0.4.0 #41726

merged 1 commit into from Jun 10, 2018

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Inits my own dwm-status package at version 0.4.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jun 9, 2018

It looks like there is already another project by this name packaged by AUR and crates.io https://repology.org/metapackage/rust-dwm-status/versions https://github.com/pierrechevalier83/rust-dwm-status. Can you comment on why yours has the same name, how it differs, and if you are planning to publish it to crates.io too?

@Gerschtli
Copy link
Contributor Author

Thats not correct. The package you mentioned has the name rust-dwm-status, mine is simply called dwm-status and it is already published at crates.io: https://crates.io/crates/dwm-status

The difference to rust-dwm-status is, that my package is more efficient because it listens for dbus signals or file changes and it is more configurable, so that you can use different ordering of elements in the status bar. I'm planning to add more configuration options if I have the time or anyone shows interest in my package.

@ryantm
Copy link
Member

ryantm commented Jun 9, 2018

@GrahamcOfBorg build dwm-status

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dwm-status

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0
shrinking /nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0/bin/dwm-status
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0/bin
patching script interpreter paths in /nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0
checking for references to /build in /nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0...
/nix/store/ijq62zlhqwh7p6wafyc3f07ss1diggpi-dwm-status-0.4.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: dwm-status

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `dwm-status`.

To learn more, run the command again with --verbose.
builder for '/nix/store/k1gcb31qfcgbnh6phrcyrl0g5mx1rjrs-dwm-status-0.4.0.drv' failed with exit code 101
error: build of '/nix/store/k1gcb31qfcgbnh6phrcyrl0g5mx1rjrs-dwm-status-0.4.0.drv' failed

@Gerschtli
Copy link
Contributor Author

@ryantm Do you have an idea how to fix the error on darwin?

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: dwm-status

Partial log (click to expand)

cannot build derivation '/nix/store/d3rwisc8c7v8014h4xb7fcgz8rbcqbfp-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9sa8yv3xwz2sb2n27gpsilrixp3q9sp5-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/shby75cn3sfr3d0jjm00m1qcg1lq4gyk-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/1rq5aq6mm6lq4h4ks532xfgh02yk3gwn-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/9mj7md06x9xwy73nv7msk2l50np8yzzn-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/fws2aw2iw7r0fbsfjz5gy9nbck5m98ff-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/kss3l6r2xhbaa00jdwz0r09ggdcfkhf9-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/z9vb9pspvhrbnk0j3bzkhhyj2wii0qz4-dwm-status-0.4.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x3phs5lk29i0rj1qjq84x3h2f33j4pmv-dwm-status-0.4.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/x3phs5lk29i0rj1qjq84x3h2f33j4pmv-dwm-status-0.4.0.drv' failed

@ryantm
Copy link
Member

ryantm commented Jun 9, 2018

@Gerschtli It looks like it is missing inotify. I don't know if that exists on Darwin. Are you expecting dwm-status to work on Darwin? If you aren't you could do

platforms = platforms.linux

If it dwm-status works without inotify, you could turn off inotify on Darwin, maybe like

++ optionals stdenv.isLinux [ inotify-tools ];

@Gerschtli
Copy link
Contributor Author

You are right, I don't expect this package to be run on Darwin, fixed it

@Gerschtli
Copy link
Contributor Author

And the aarch64 build failure is caused by the usual timeout with rust packages..

@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build dwm-status

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dwm-status

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dwm-status

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0
shrinking /nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0/bin/dwm-status
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0/bin
patching script interpreter paths in /nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0
checking for references to /build in /nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0...
/nix/store/3b689iyl13g7ydgk31plwf5pwry8l51r-dwm-status-0.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dwm-status

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0
shrinking /nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0/bin/dwm-status
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0/bin
patching script interpreter paths in /nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0
checking for references to /build in /nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0...
/nix/store/d9zhhqmwpmkgkmqkajvsbqbw1vlw0hjp-dwm-status-0.4.0

@xeji xeji merged commit 895e4c2 into NixOS:master Jun 10, 2018
@andir
Copy link
Member

andir commented Jun 10, 2018

Thank you for the package. It looks nice and I'll probably give it a shot soon :)

Have you considered declaring the runtime dependency "xsetroot" in the package? It probably only works (on NixOS) because the xserver module puts that binary in the system path. If you are running dwm-status on any non-nixos system that is using nix that will probably fail (unless it is in the PATH by accident).

@Gerschtli
Copy link
Contributor Author

That sounds reasonable, xorg.xsetroot and optionally alsaUtils should be included as runtime dependencies. I will open another PR to add these.

Thank you!

@Gerschtli Gerschtli deleted the add/dwm-status branch June 10, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants