-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gperftools: 2.6.3 -> 2.7 #41701
gperftools: 2.6.3 -> 2.7 #41701
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gperftools/versions. These checks were done: - built on NixOS - /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/bin/pprof passed the binary check. - 1 of 1 passed binary check by having a zero exit code. - 0 of 1 passed binary check by having the new version present in output. - found 2.7 with grep in /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7 - directory tree listing: https://gist.github.com/563708d434af605d1d26161b144b73c0 - du listing: https://gist.github.com/6feff1a0de5dc812f3e49aa97551174a
Failure on x86_64-darwin (full log) Attempted: gperftools Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gperftools Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gperftools Partial log (click to expand)
|
Darwin would become a regression, apparently, as it seems to build now: https://hydra.nixos.org/job/nixpkgs/trunk/gperftools.x86_64-darwin EDIT: the real error there is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix darwin build
@GrahamcOfBorg build gperftools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- reviewed the diff and commit messages
- made sure ofBorg build succeeded for all applicable platforms
- run nix-review without any failures
- run and tested the binaries
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/gperftools/versions.
These checks were done:
meta.description for gperftools is: '"Fast, multi-threaded malloc() and nifty performance analysis tools"'.
cc @vcunat @wkennington for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
Test this build: