Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gperftools: 2.6.3 -> 2.7 #41701

Merged
merged 1 commit into from Aug 10, 2019
Merged

gperftools: 2.6.3 -> 2.7 #41701

merged 1 commit into from Aug 10, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jun 8, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/gperftools/versions.

These checks were done:

meta.description for gperftools is: '"Fast, multi-threaded malloc() and nifty performance analysis tools"'.

cc @vcunat @wkennington for testing.

Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout 769fa7ad769d38ce86f14536c453826fd67e77ce && nix-shell --pure -I nixpkgs=. -p gperftools

gperftools: 2.6.3 -> 2.7
769fa7a 
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/gperftools/versions.

These checks were done:

- built on NixOS
- /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/bin/pprof passed the binary check.
- 1 of 1 passed binary check by having a zero exit code.
- 0 of 1 passed binary check by having the new version present in output.
- found 2.7 with grep in /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7
- directory tree listing: https://gist.github.com/563708d434af605d1d26161b144b73c0
- du listing: https://gist.github.com/6feff1a0de5dc812f3e49aa97551174a
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gperftools

Partial log (click to expand)

In file included from ./src/base/commandlineflags.h:56:
./src/base/basictypes.h:311:9: warning: '_dyld_present' is deprecated: first deprecated in macOS 10.5 [-Wdeprecated-declarations]
    if (_dyld_present()) {
        ^
/nix/store/xn55wd7nimdi085kji54mrrqqnqvcasz-Libsystem-osx-10.11.6/include/mach-o/dyld.h:230:13: note: '_dyld_present' has been explicitly marked deprecated here
extern bool _dyld_present(void)                                                              __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_1,__MAC_10_5,__IPHONE_NA,__IPHONE_NA);
            ^
1 warning generated.
builder for '/nix/store/r0ih229kkkdrf18inwx69sh9jjv3ykkc-gperftools-2.7.drv' failed with exit code 2
error: build of '/nix/store/r0ih229kkkdrf18inwx69sh9jjv3ykkc-gperftools-2.7.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gperftools

Partial log (click to expand)

shrinking /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/lib/libtcmalloc.so.4.5.3
shrinking /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/lib/libtcmalloc_debug.so.4.5.3
shrinking /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/lib/libprofiler.so.0.4.18
shrinking /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/lib/libtcmalloc_and_profiler.so.4.5.3
gzipping man pages under /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/lib  /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7/bin
patching script interpreter paths in /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7
checking for references to /build in /nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7...
/nix/store/8y8rcib0axcnrrq1xvg9yn3vn3i2a323-gperftools-2.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gperftools

Partial log (click to expand)

shrinking /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/lib/libtcmalloc_debug.so.4.5.3
shrinking /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/lib/libtcmalloc.so.4.5.3
shrinking /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/lib/libtcmalloc_minimal_debug.so.4.5.3
shrinking /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/lib/libtcmalloc_minimal.so.4.5.3
gzipping man pages under /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/lib  /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7/bin
patching script interpreter paths in /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7
checking for references to /build in /nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7...
/nix/store/0klw0vsh5l2ylw75b3c5jpl34crcc1c7-gperftools-2.7

@vcunat
Copy link
Member

vcunat commented Jun 9, 2018 •
edited

Darwin would become a regression, apparently, as it seems to build now: https://hydra.nixos.org/job/nixpkgs/trunk/gperftools.x86_64-darwin

EDIT: the real error there is

error: 'operator delete[]' is unavailable: introduced in macOS 10.12

xeji
xeji suggested changes Jun 10, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix darwin build

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

@GrahamcOfBorg build gperftools

mmahut
mmahut approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit 2aa7589 into NixOS:master Aug 10, 2019
@r-ryantm r-ryantm deleted the auto-update/gperftools branch August 17, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @GrahamcOfBorg @vcunat @mmahut @xeji @infinisil