Set User-Agent header to 'DokuWiki HTTP Client (Extension Manager)' #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think instead of adding another parameter to the io_download method, I would prefer to let the Extension manager instantiate it's own DokuHTTPClient, doing the download without io_download's help |
|
Ok, will have a look into that. |
lpaulsen93
force-pushed
the
HTTPClientAgent
branch
from
105090b
to
be3c74b
Compare
|
Done. |
…Manager)' This solves problems with project hosters which do not start an download immediately if the User-Agent seems to be a browser, also see #2410.
lpaulsen93
force-pushed
the
HTTPClientAgent
branch
from
d2b05eb
to
bf209a6
Compare
|
It would be cool if this could be merged so that we can re-run the check for the extension cleanup and see how many plugins are fixed by this. |
splitbrain
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes download/installation problems for plugins which are hosted on SourceForge.