nixos: Add option networking.networkmanager.dynamicHosts #41715
Merged
+81
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows non-privileged users to configure local DNS entries by editing hosts files read by NetworkManager's dnsmasq instance.
GrahamcOfBorg
added
6.topic: nixos
|
I'm going to merge this, since it has been working flawlessly for me for a long time, and since nothing will be affected if the option is not enabled. If someone strongly opposes this, I'll revert it. |
|
After an building Nix...
building the system configuration...
error:
Failed assertions:
- To use networking.networkmanager.dynamicHosts you also need to enable
networking.networkmanager.useDnsmasqI tried to set What do I miss? |
rickynils
added a commit
that referenced
this pull request
Jul 3, 2018
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This allows non-privileged users to configure local DNS
entries by editing hosts files read by NetworkManager's dnsmasq
instance.
This adds a new option
networking.networkmanager.dynamicHosts, and if it isn't enabled (disabled by default), nothing will change for end users.If this is accepted, I'll create a PR for master too.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)