wireguard-go: remove from tree #41710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very disappointing to submit. This .nix was accepted into nixpkgs in very poor state, and it took some efforts to even clean it up to be acceptable. During the process, the original submitter (and maintainer) was nowhere to be found and did not participate. Since then, the maintainer of the package has failed to update it, to the point where the current version in the tree no longer works properly with the tools. (We intentionally made some breaking changes while we were shaking out bugs from the _first ever darwin release_.) But probably the maintainer of the package isn't really aware of that. In otherwords, this seems unmaintained. And for a project that's still based on _snapshots_, it seems important to have active interested maintainers who are using this stuff, following the project, and bumping releases accordingly. Therefore, I think the choices at hand are: find a new maintainer for this, or just remove it. I hope you'll do the former; maybe it will come down to the latter, which is what this commit does.
|
CC: @Mic92 @kirelagin |
|
As an update in activities, I've now emailed @kirelagin in order to direct his attention toward this PR. |
|
closing in favor of #41735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very disappointing to submit.
This .nix was accepted into nixpkgs in very poor state, and it took some
efforts to even clean it up to be acceptable. During the process, the
original submitter (and maintainer) was nowhere to be found and did not
participate.
Since then, the maintainer of the package has failed to update it, to
the point where the current version in the tree no longer works properly
with the tools. (We intentionally made some breaking changes while we
were shaking out bugs from the first ever darwin release.) But
probably the maintainer of the package isn't really aware of that.
In otherwords, this seems unmaintained. And for a project that's still
based on snapshots, it seems important to have active interested
maintainers who are using this stuff, following the project, and bumping
releases accordingly.
Therefore, I think the choices at hand are: find a new maintainer for
this, or just remove it. I hope you'll do the former; maybe it will come
down to the latter, which is what this commit does.
As a point of clarification, based on an IRC inquiry: this PR here concerns the
wireguard-gopackage. Thewireguard-toolsandwireguard-modulespackages have different maintainers from this one, and those maintainers have been very on top of things for a long time now. So this PR has nothing to do with those two packages, but rather onlywireguard-go.