Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use "with stdenv.lib" in meta #40931

Merged
merged 1 commit into from May 22, 2018
Merged

doc: use "with stdenv.lib" in meta #40931

merged 1 commit into from May 22, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 22, 2018 •
edited

Motivation for this change

People would not accept a PR to nixpkgs where stdenv.lib. occurs three times. Documentation should not suggest things that are clearly not allowed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

lukateras
lukateras approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lukateras lukateras merged commit 2eea6a4 into NixOS:master May 22, 2018
@veprbl veprbl deleted the pr/with_stdenv_lib_meta branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @lukateras @GrahamcOfBorg