Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libgsystem #40923

Merged
merged 6 commits into from
Jun 24, 2018
Merged

Remove libgsystem #40923

merged 6 commits into from
Jun 24, 2018
+128 −92

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented May 22, 2018 •
edited
Loading

Motivation for this change

libgsystem is deprecated. It is only required by rpm-ostree, updating will allow us to drop it.

Update, clean up dependencies, and add installed tests.

Tests currently fail see ostreedev/ostree#1593 and ostreedev/ostree#1592

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jtojnar jtojnar added the 2.status: work-in-progress This PR isn't done label May 22, 2018
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 22, 2018
@jtojnar jtojnar changed the title ostree: 2018.4 → 2018.5 Remove libgsystem Jun 3, 2018
@jtojnar jtojnar requested a review from copumpkin June 3, 2018 01:25
@jtojnar jtojnar force-pushed the libgsystem branch 2 times, most recently from 6b658e2 to 6b97119 Compare June 5, 2018 15:49
@copumpkin
Copy link
Member

Thanks! In principle it looks good but I don't use ostree anymore so can't really test it in any sort of realistic workflow. Happy to merge if it's ready though.

@jtojnar
Copy link
Member Author

jtojnar commented Jun 5, 2018

There is no hurry, we can probably wait for a patch for ostreedev/ostree#1592.

@jtojnar
Copy link
Member Author

jtojnar commented Jun 19, 2018

@GrahamcOfBorg test ostree

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.ostree

Partial log (click to expand)

error: Attempt to end element "line" with "nest" tag at /nix/store/pa72glydysl826fnvzva6icw9pd96203-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
Attempt to end element "line" with "nest" tag at /nix/store/pa72glydysl826fnvzva6icw9pd96203-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
cleaning up
killing machine (pid 593)
Attempt to end element "line" with "logfile" tag at /nix/store/pa72glydysl826fnvzva6icw9pd96203-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 27.
END failed--call queue aborted, <__ANONIO__> line 4493.
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/10400abn5cw3rz581dg5liljq2lizjps-vm-test-run-ostree.drv' failed with exit code 22
error: build of '/nix/store/10400abn5cw3rz581dg5liljq2lizjps-vm-test-run-ostree.drv' failed

@jtojnar jtojnar mentioned this pull request Jun 19, 2018
Merged
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.ostree

Partial log (click to expand)

error: Attempt to end element "line" with "nest" tag at /nix/store/1m48klh9d8m6kl0ng6cyzv2q6kxl6fz9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
Attempt to end element "line" with "nest" tag at /nix/store/1m48klh9d8m6kl0ng6cyzv2q6kxl6fz9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
cleaning up
killing machine (pid 627)
Attempt to end element "line" with "logfile" tag at /nix/store/1m48klh9d8m6kl0ng6cyzv2q6kxl6fz9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 27.
END failed--call queue aborted, <__ANONIO__> line 4492.
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/i3wjfzar9hw7mg3qpriyw9ah4xp7fw1s-vm-test-run-ostree.drv' failed with exit code 22
error: build of '/nix/store/i3wjfzar9hw7mg3qpriyw9ah4xp7fw1s-vm-test-run-ostree.drv' failed

@jtojnar jtojnar merged commit 5222f36 into NixOS:master Jun 24, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-linux: 1-10 labels Jun 24, 2018
@jtojnar jtojnar deleted the libgsystem branch July 15, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @copumpkin @GrahamcOfBorg