Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd-timesyncd.service: use the correct server list #40919

Merged
merged 1 commit into from May 24, 2018
Merged

systemd-timesyncd.service: use the correct server list #40919

merged 1 commit into from May 24, 2018

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented May 22, 2018 •
edited

Motivation for this change

The module ignored its own server list. Fixes #34671.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented May 22, 2018

Successfully tested on my system.

@joachifm
Copy link
Contributor

LGTM. I wonder if it's worth adding a note about this, in case somebody is relying on services.ntp.servers & not being aware of the more appropriate networking.timeServers option?

@joachifm joachifm merged commit c42cb40 into NixOS:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokudan @joachifm @GrahamcOfBorg