Skip to content

Remove "v" in "installed version" and "latest version" columns #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

yalov
Copy link
Contributor

@yalov yalov commented May 21, 2018

v3.4.5-whatever → 3.4.5-whatever
V.3.4.5         → 3.4.5
Version_3.4.5   → 3.4.5
V21             → 21
vessel_5.1      → vessel_5.1

cons:

V1deo → 1deo

Not sure what is 2 in 2:v3.4.5, and why it in LatestVersion and not in the GUI column, I mean where 2: is removed from LatestVersion, but 2: is leaved there.

2:v3.4.5 → 2:3.4.5

@politas
Copy link
Member

politas commented May 22, 2018

Why do we want to mess with the version numbers chosen by mod makers? We should try to present mod version numbers in the same way they are presented in their sources and their forum threads.

FYI, the "2:" you are seeing there is an epoch, and that is a extra element we add at times in order to force correct mod version ordering when mod authors accidentally take their versions backwards. We have a setting to hide them in the mod list, which is on by default. We should hide epochs on the latest version column if we're hiding them in the installed version column.

To add this feature, there should definitely be a option in settings, and it should be off (thus displaying the "v"s) by default.

@yalov
Copy link
Contributor Author

yalov commented May 22, 2018

semver/semver#235

In my opinion the leading 'v' belongs to a tag (e.g. on a git repo) but does not belong to the version string itself

@politas
Copy link
Member

politas commented May 22, 2018

Sure, but how many mod authors are actually following SemVer precisely versus copying what they have seen other people do? For that matter, I suppose I'm not using it correctly on our forum thread.

As an example, check out https://spacedock.info/mod/234 version history. It's all messed up. We're probably going to have to slap an epoch on that mod to get it back into order the next time they change their version string.

Like I said, make it an option that people can turn on if they want to.

@yalov
Copy link
Contributor Author

yalov commented May 22, 2018

We have a setting to hide them in the mod list

then maybe also hide from update or install mods process window?

check out [x]Science SCAN Version Tab - not sure what happens there, but looks like really vV5.13 < v5.14, epoch is needed.
SEP uses v-or-not-v by random, that why 2.1.5 in the bottom.
QuickStart changed author, so v is disappeared and epoch is neaded.

All this wouldn't be there if v is excluded from SCAN in the core... in the some 'Version' core-object ?

@politas
Copy link
Member

politas commented May 22, 2018

#963 is relevant here.

@politas
Copy link
Member

politas commented May 22, 2018

@politas
Copy link
Member

politas commented May 22, 2018

Changing the display of version numbers is ok (as long as we allow people to keep things as they have been in the past) Changing the version comparison in the Core means breaking compatibility.

Sorry, something went wrong.

@politas politas merged commit adcb91b into KSP-CKAN:master Jun 4, 2018
politas added a commit that referenced this pull request Jun 4, 2018

Verified

This commit was signed with the committer’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants