Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binutils: Always apply Aarch64 patch #40930

Merged
merged 1 commit into from May 22, 2018
Merged

binutils: Always apply Aarch64 patch #40930

merged 1 commit into from May 22, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Otherwise various things which depend on --enable-targets=all lib{bfd,opcodes}...like LLVM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
binutils: Always apply Aarch64 patch
afc439d 
Otherwise various things which depend on `--enable-targets=all`
lib{bfd,opcodes}...like LLVM.
@Ericson2314 Ericson2314 merged commit 75638e2 into NixOS:staging May 22, 2018
@Ericson2314 Ericson2314 deleted the binutils-always-patch branch May 22, 2018 17:32
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: binutils

Partial log (click to expand)

copying path '/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19' from 'https://cache.nixos.org'...
copying path '/nix/store/4rjykqway119py3g7wdih2ldkm99fpxd-expand-response-params' from 'https://cache.nixos.org'...
copying path '/nix/store/346ra1dih2vvafsb995kmmjs35hmm86h-glibc-2.27-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/1q78lmf12naxbkdazc8prbjdw0a9xklq-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/4r95xrxds4ybnjmi4f60286hck3vlyd7-acl-2.2.52' from 'https://cache.nixos.org'...
copying path '/nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/nnkwjkcjqw94knaxpzwl7sysx72xab3z-coreutils-8.29' from 'https://cache.nixos.org'...
copying path '/nix/store/1039mfsxv4a2yk3b4vbf1k1xpvm9nn38-glibc-2.27-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/k7444rv178lhj1ppadlsa3qbczs074zh-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
/nix/store/k7444rv178lhj1ppadlsa3qbczs074zh-binutils-wrapper-2.30

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: binutils

Partial log (click to expand)

unpacking sources
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pix6rl8c0197jbv1yq1r4j8djg3m993n-binutils-wrapper-2.30
checking for references to /build in /nix/store/pix6rl8c0197jbv1yq1r4j8djg3m993n-binutils-wrapper-2.30...
Using dynamic linker: '/nix/store/bgl62l4ly7xfsdwqp93cqw3kqbwchdrd-glibc-2.27/lib/ld-linux-x86-64.so.2'
/nix/store/pix6rl8c0197jbv1yq1r4j8djg3m993n-binutils-wrapper-2.30

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: binutils

Partial log (click to expand)

cannot build derivation '/nix/store/23px6awsa6plw0y7g454j6zn1v967dby-CF-osx-10.10.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lkda1x4w3in7ak0rjrqxv9pnjgii4jvz-bootstrap-stage4-stdenv-darwin.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/n4jlsqwgssyb365h3nf958y8rjqbxlrb-bootstrap-stage4-stdenv-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/wcv7p6nn9cxvivv6bkcrnhj72g7khb9n-expand-response-params.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/l6952drd45qwda4jrr1ympy0qjncsbyn-gnum4-1.4.18.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hvllczl5zlpm6n3lb3zl2fl5s80lkvlb-perl-5.24.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/idjwdpkmi3chgk9jsrp13j0q1hkzfjqv-bison-3.0.4.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lfqny1hdpmw724b9jdd780809k0qcbf3-binutils-2.30.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/5bg86psxwccvfd5z4n83aq6dk9gnd0wr-binutils-wrapper-2.30.drv': 7 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/5bg86psxwccvfd5z4n83aq6dk9gnd0wr-binutils-wrapper-2.30.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg