Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kakoune-unstable: 2018-03-22 -> 2018-05-21, debug mode disabled #40889

Merged
merged 1 commit into from May 22, 2018
Merged

kakoune-unstable: 2018-03-22 -> 2018-05-21, debug mode disabled #40889

merged 1 commit into from May 22, 2018

Conversation

GrigoriyDmitriev
Copy link
Contributor

@GrigoriyDmitriev GrigoriyDmitriev commented May 21, 2018 •
edited

Motivation for this change

Kakoune version provided in nixpkgs was quite old, and debug mode is generally not recommended to use.

Note that if your distribution provides a "kakoune" package, the program should already be built in non-debug mode (if you still experience slowness, please report the issue on the bug tracker).

From https://github.com/mawww/kakoune/blob/master/doc/pages/faq.asciidoc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 22, 2018

@GrahamcOfBorg build kakoune

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: kakoune

Partial log (click to expand)

[ -e /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/kak/autoload ] || ln -s rc /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/kak/autoload
install -m 0644 ../colors/* /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/kak/colors
install -m 0644 ../README.asciidoc /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/doc/kak
install -m 0644 ../doc/kak.1.gz /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21/bin
patching script interpreter paths in /nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21
/nix/store/hxyx0l589xyv70cnfx7jmxcby0ah5jfq-kakoune-unstable-2018-05-21

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kakoune

Partial log (click to expand)

install -m 0644 ../doc/kak.1.gz /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21
shrinking /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21/bin/kak
gzipping man pages under /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21/bin
patching script interpreter paths in /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21
checking for references to /build in /nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21...
/nix/store/iwnl3vzmqaag13qhg7dhr5c9q4348lxb-kakoune-unstable-2018-05-21

@xeji
Copy link
Contributor

xeji commented May 22, 2018

Thank you!

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kakoune

Partial log (click to expand)

install -m 0644 ../doc/kak.1.gz /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21
shrinking /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21/bin/kak
gzipping man pages under /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21/bin
patching script interpreter paths in /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21
checking for references to /build in /nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21...
/nix/store/45pdbqx7bllxpnv0sgx9s14chxf27392-kakoune-unstable-2018-05-21

@xeji xeji merged commit 8b29ccb into NixOS:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GrigoriyDmitriev @xeji @GrahamcOfBorg @Janik-Haag