Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyogg: init at 0.6.2a1 #40885

Merged
merged 1 commit into from May 22, 2018
Merged

pyogg: init at 0.6.2a1 #40885

merged 1 commit into from May 22, 2018

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

The package is missing in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner May 21, 2018 17:35
@FRidh
Copy link
Member

FRidh commented May 21, 2018

@GrahamcOfBorg build python2.pkgs.pyogg python3.pkgs.pyogg

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pyogg, python3.pkgs.pyogg

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'PyOgg.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/l4mcvqgw36djh2x4ccq8abwv1f003ig8-python2.7-PyOgg-0.6.2a1
/nix/store/aps3ycr8lrz4bcmircrma04sfcdyx7xx-python3.6-PyOgg-0.6.2a1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pyogg, python3.pkgs.pyogg

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'PyOgg.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/qzzn9pxyyg2r6fgqyi4wc8nrpppvnjqa-python2.7-PyOgg-0.6.2a1
/nix/store/r79qb0kwxys3lgj2lp95n1ms6gp6n54h-python3.6-PyOgg-0.6.2a1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pyogg, python3.pkgs.pyogg

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'PyOgg.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ilr9y8x2a981a0synxkzq5vgzdqz19b5-python2.7-PyOgg-0.6.2a1
/nix/store/q21nfv2dd75dj9a9rjhqv5z9gxbqnqd9-python3.6-PyOgg-0.6.2a1

@FRidh
Copy link
Member

FRidh commented May 21, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@pmiddend
Copy link
Contributor Author

Ah, didn't know that rule. There are no tests, so I disabled them and left a comment.

@FRidh FRidh merged commit 9f87abd into NixOS:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @FRidh @GrahamcOfBorg