partition-manager: 3.0.1 -> 3.3.1 #40895
Conversation
|
Success on x86_64-linux (full log) Attempted: partition-manager Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: partition-manager Partial log (click to expand)
|
| nativeBuildInputs = [ extra-cmake-modules kdoctools wrapGAppsHook ]; | ||
|
|
||
| # refer to kpmcore for the use of eject | ||
| buildInputs = [ eject libatasmart utillinux makeWrapper ]; |
There was a problem hiding this comment.
makeWrapper belongs in nativeBuildInputs.
| propagatedBuildInputs = [ kconfig kcrash kinit kpmcore ]; | ||
|
|
||
| postInstall = '' | ||
| wrapProgram "$out/bin/partitionmanager" --prefix QT_PLUGIN_PATH : "${kpmcore}/lib/qt-5.${lib.versions.minor qtbase.version}/plugins" |
There was a problem hiding this comment.
With this, the program is wrapped twice: once by wrapGAppsHook (why, it's a KDE app?) and once by makeWrapper. Looks quite ugly. Any chance you can make it work with only one wrapper?
thanks, missed that 👍
I'm admittedly not sure, that's been introduced in be7b7d9. |
|
It seems as we can't (or shouldn't) drop This happens even when using Unfortunately I don't know too much about the wrappers, so unless you have an idea how to simplify this I'd suggest to keep it for now as this repairs the build at least and makes the package functional again :-) |
The `3.0.1` build was broken (see the Hydra build from https://hydra.nixos.org/build/74368257 for further reference). Because of the missing `utillinux` build input the package fails fairly early: ``` -- Checking for module 'blkid' -- No package 'blkid' found CMake Error at /nix/store/9hmhxgj4jk6jmxihgavj6gm0p759misc-cmake-3.10.2/share/cmake-3.10/Modules/FindPkgConfig.cmake:415 (message): A required package was not found ``` Additionally `partition-manager` was broken on non-KDE desktops (none+i3 in my case) as the plugins from `libsForQt5.kpmcore` couldn't be found in `QT_PLUGIN_PATH` unless it's installed in `environment.systemPackages` or with `nix-env -iA libsForQt5.kpmcore`. This has been fixed by adding a wrapper in the `postInstall` hook which prefixes the `QT_PLUGIN_PATH` with the plugin path from `kpmcore` used for the build.
Ma27
force-pushed
the
fix-partition-manager
branch
from
3f88096
to
d0b6e7e
Compare
|
Success on x86_64-linux (full log) Attempted: partition-manager Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: partition-manager Partial log (click to expand)
|
|
I don't know much about |
Motivation for this change
The
3.0.1build was broken (see the Hydra build fromhttps://hydra.nixos.org/build/74368257 for further reference).
Because of the missing
utillinuxbuild input the package fails fairlyearly:
Additionally
partition-managerwas broken on non-KDE desktops (none+i3in my case) as the plugins from
libsForQt5.kpmcorecouldn't be foundin
QT_PLUGIN_PATHunless it's installed inenvironment.systemPackagesor withnix-env -iA libsForQt5.kpmcore.This has been fixed by adding a wrapper in the
postInstallhook whichprefixes the
QT_PLUGIN_PATHwith the plugin path fromkpmcoreusedfor the build.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)