Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom: 1.27.0 -> 1.27.1, atom-beta: 1.24.0-beta3 -> 1.28.0-beta1 #40886

Merged
merged 1 commit into from May 22, 2018
Merged

atom: 1.27.0 -> 1.27.1, atom-beta: 1.24.0-beta3 -> 1.28.0-beta1 #40886

merged 1 commit into from May 22, 2018

Conversation

Synthetica9
Copy link
Member

Also rewrote the derivation for easier maintencence.

(And added @ysndr as maintainer for atom-beta, kind of an implicit
result of joining the two. If you're not okay with that, I'll patch
you out, but I'll presume consent.)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom

Partial log (click to expand)

/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/resources/app/apm/node_modules/node-gyp/gyp/gyp: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/bin/.atom-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1...
cannot find section .dynamic
file /nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/atom had a PT_GNU_STACK program header, converted
file /nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1/share/atom/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/3flf6ll6i935d1v98wvr36yd9xf5q9wb-atom-1.27.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom

Partial log (click to expand)

/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/apm/node_modules/keytar/script/cibuild: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/apm/script/postinstall.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/atom.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1...
cannot find section .dynamic
file /nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/atom had a PT_GNU_STACK program header, converted
file /nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1/share/atom/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/s9m9j0kjvq3jscx5mzjhn8d59h2g7q1v-atom-1.27.1

@xeji
Copy link
Contributor

xeji commented May 22, 2018

@GrahamcOfBorg build atom-beta

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: atom-beta

Partial log (click to expand)

/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/script/postinstall.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/atom.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1...
cannot find section .dynamic
ln: failed to create symbolic link '/nix/store/0s6jlnwphbr77gs99aizfw6n8nxb2c7d-atom-beta-1.28.0-beta1/share/atom/resources/app.asar.unpacked/node_modules/dugite/git/bin/git': No such file or directory
builder for '/nix/store/wp8y4pv5g3hvl5ckmj6ngajmd6qdwwv5-atom-beta-1.28.0-beta1.drv' failed with exit code 1
error: build of '/nix/store/wp8y4pv5g3hvl5ckmj6ngajmd6qdwwv5-atom-beta-1.28.0-beta1.drv' failed

xeji
xeji reviewed May 22, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build of atom-beta (it fails on my local machine too).
The atom version is 1.27.1 but your PR and the commit messages say 1.27.7.

@Synthetica9
atom, atom-beta: 1.27.0 -> 1.27.1, 1.24.0-beta3 -> 1.28.0-beta1
2ad8e9a 
Also rewrote the derivation for easier maintencence.

(And added @ysndr as maintainer for atom-beta, kind of an implicit
result of joining the two. If you're not okay with that, I'll patch
you out, but I'll presume consent.)
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom, atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom, atom-beta

Partial log (click to expand)

/nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/bin/.atom-beta-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1...
cannot find section .dynamic
file /nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/share/atom-beta/atom had a PT_GNU_STACK program header, converted
file /nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1/share/atom-beta/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/ayvsqrca7zscxvcw2apl60l5zi4v38na-atom-1.27.1
/nix/store/6s4nhhgsrw97gr48673x80zywscxvqax-atom-beta-1.28.0-beta1

@Synthetica9
Copy link
Member Author

@xeji ✔️

@xeji xeji changed the title atom: 1.27.0 -> 1.27.7, atom-beta: 1.24.0-beta3 -> 1.28.0-beta1 atom: 1.27.0 -> 1.27.1, atom-beta: 1.24.0-beta3 -> 1.28.0-beta1 May 22, 2018
@xeji xeji merged commit 41344b8 into NixOS:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @xeji