Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-du: init at 0.1.1 #40896

Merged
merged 1 commit into from May 22, 2018
Merged

nix-du: init at 0.1.1 #40896

merged 1 commit into from May 22, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

package https://github.com/symphorien/nix-du

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented May 22, 2018

@GrahamcOfBorg build nix-du

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-du

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1
shrinking /nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1/bin/nix-du
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1/bin
patching script interpreter paths in /nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1
checking for references to /build in /nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1...
/nix/store/s4vfzi6wg1mab1h0vqkpp3gjq6353x7a-nix-du-0.1.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nix-du

Partial log (click to expand)


failures:
    k2_1
    simple

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test common'
builder for '/nix/store/20hs9n27y8yh0s0m63r0rw2ffr6s7gap-nix-du-0.1.1.drv' failed with exit code 101
�[31;1merror:�[0m build of '/nix/store/20hs9n27y8yh0s0m63r0rw2ffr6s7gap-nix-du-0.1.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-du

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1
shrinking /nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1/bin/nix-du
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1/bin
patching script interpreter paths in /nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1
checking for references to /build in /nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1...
/nix/store/17d8crcsx6x4hc71f0x2rscwbpirx1dl-nix-du-0.1.1

@Mic92
Copy link
Member

Mic92 commented May 22, 2018

@grahamc do we have a sandbox again on macOS? sandbox-exec: sandbox_apply_container: Operation not permitted seems like it does.

@symphorien
Copy link
Member Author

I might be because the test suite runs nix (on a local, temporary store). I think the error messages come from these nix invocations. Unfortunately I can't test on MacOS. Do you think adding the option --option sandbox false when running the tests would help ?
otherwise I will just set doCheck to false on darwin.

@Mic92
Copy link
Member

Mic92 commented May 22, 2018

It should help, if it runs nix in single-user mode.

@symphorien
Copy link
Member Author

so I just pushed a patch to add --option sandbox false, can someone invoke @GrahamcOfBorg again ?

@Mic92
Copy link
Member

Mic92 commented May 22, 2018

@GrahamcOfBorg build nix-du

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nix-du

Partial log (click to expand)


failures:
    k2_1
    simple

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test common'
builder for '/nix/store/pdkb1jjg6zyf81an9nsvckvwspqgs8cw-nix-du-0.1.1.drv' failed with exit code 101
�[31;1merror:�[0m build of '/nix/store/pdkb1jjg6zyf81an9nsvckvwspqgs8cw-nix-du-0.1.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-du

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1
shrinking /nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1/bin/nix-du
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1/bin
patching script interpreter paths in /nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1
checking for references to /build in /nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1...
/nix/store/hl867iq6gakfdvcxfgwz7afb1xs3iish-nix-du-0.1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-du

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1
shrinking /nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1/bin/nix-du
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1/bin
patching script interpreter paths in /nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1
checking for references to /build in /nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1...
/nix/store/swknqfbv3xj85x4xw4aqarj7igq3962p-nix-du-0.1.1

@symphorien
Copy link
Member Author

Ok this just disables tests for now on darwin.

@Mic92 Mic92 merged commit c8a4562 into NixOS:master May 22, 2018
@symphorien
Copy link
Member Author

symphorien commented May 22, 2018 •
edited

Just if you are curious why it failed even when disabling the sandbox:
nix uses a minimal sandbox even if --option sandbox false is passed. To disable it
an environment variable is needed.
https://github.com/NixOS/nix/blob/c717d8e3bd96db9a597e11f067585cf1aee50a40/src/libstore/build.cc#L2818

@Mic92
Copy link
Member

Mic92 commented May 23, 2018 •
edited

Interesting. Too bad macOS does not allow to nest those like Linux does.

@symphorien symphorien mentioned this pull request Jun 10, 2018
Closed
@symphorien symphorien deleted the nix-du branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @Mic92 @GrahamcOfBorg