Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jopenssl24 set_key methods #166

Merged
merged 2 commits into from Jun 1, 2018
Merged

Fix jopenssl24 set_key methods #166

merged 2 commits into from Jun 1, 2018

Conversation

jboler
Copy link
Contributor

@jboler jboler commented May 31, 2018

With jRuby 9.2.0.0 which targets Ruby 2.5 I'm getting:

NoMethodError: undefined method `public_key=' for #<OpenSSL::PKey::DSA:0x64b83f76>

It works fine when I use pub_key=

@jboler
Copy link
Contributor Author

jboler commented Jun 1, 2018

This bug will now manifest on jRuby 9.1.18.0 if it's released without this fix. Previously the bug wasn't loaded on 9.1 because of load 'jopenssl24.rb' if RUBY_VERSION >= '2.4'.

@kares kares merged commit 4b67129 into jruby:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants