@pesterhazy @flokli As maintainers of oracle-instantclient you may also be interested in this.

@mulderr funny thing, odpi also comes as a submodule of cx_python (IIRC). Maybe you want to apply the patch from there here as well, or even use this separate odpi drv for everything.

This one right?

Documentation says that ODPI-C can be used in two different ways. As a shared library or by including the source directly in another project. I think cx_Oracle does the latter while odpic-raw currently expects the former.

The patch is just fixing the path to libclntsh? I decided to override RPATH instead. The net effect should be identical but browsing through nixpkgs patchelf seems to be the goto solution.

Hm, while I don't have immediate use for it (other than to make odpic-raw work), it makes sense to me that this should be offered as a separate library in case anyone wants to use it from C/C++ etc.

Luckily, correct me if I'm wrong, this shouldn't break cx_Oracle in any way? So any project that was using odpic directly can keep using a version independent of the one in nixpkgs - for example via git submodules as cx_Oracle does.

Overriding rpath is also possible, and probably cleaner than maintaining a patch in nixpkgs. Agreed :-)

Since oracle/python-cx_Oracle@9baa55b, it's possible to build cx_oracle with an external odpic library, so I updated my drv accordingly to use the new odpi drv:

flokli@cx_oracle-odpi-c

Could you cherry-pick that on top of your PR?

Sure! Some checks are apparently failing though. Looking into it now.

Edit: my bad. A typo in the metadata which I thought I already fixed before. Should be ok.

speaking of stdenv.hostPlatform.extensions.sharedLibrary and portability:

Took the opportunity to wire darwin support into the oracle-instantclient and odpic drvs in 620c574 and 3ebfb98490f.
@matthewbauer given that's my first darwin contribution, could you have a closer look?

Whats your opinion on the makefile patch for odpi, and what about fixDarwinDylibNames not picking up $out/lib/libodpic.dylib.2.4.0 automatically (as libodpic.dylib is a symlink and thus skipped)?

Anyways, with this PR plus above mentioned two commits, I was able to use sqlalchemy to connect to oracle databases from a Mac with Nix installed, too :-)

@mulderr patches for odpic were upstreamed (oracle/odpi#65),
I updated my oracle-instantclient-darwin branch to include the patch.

Would you mind cherry-picking my commits in here?

@flokli Done.

Fair warning though, I don't use Macs or have one handy to test so it's impossible for me to verify. If it works for you then cool. Might as well take care of this right away.

No worries. Patch removed.

LGTM. @matthewbauer, @FRidh, merge?

Thanks for all the input and for merging! Awesome.