Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 26de15d0585c
Choose a base ref
...
head repository: jruby/jruby
compare: b0875446c80d
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on May 31, 2018

  1. review StringIO code-paths that might go wrong, remove double check

    @kares
    kares committed May 31, 2018
    Copy the full SHA
    bd2b4c9 View commit details
    Browse the repository at this point in the history

  2. [fix] newStringShared - byte[] version has BUFFER sharing

    @kares
    kares committed May 31, 2018
    Copy the full SHA
    6a6ae1a View commit details
    Browse the repository at this point in the history

  3. [fix] use strBufCat as it does str.modify which is desired here

    @kares
    kares committed May 31, 2018
    Copy the full SHA
    088f80f View commit details
    Browse the repository at this point in the history

  4. [refactor] cleanup getLine call internals - use direct nil check 

    motivated by confusing `!enc.isAscii` check followed by `catAscii(...)`
    @kares
    kares committed May 31, 2018
    Copy the full SHA
    1260e36 View commit details
    Browse the repository at this point in the history

  5. [fix] potential string sharing as each_line returns shared buffer 

    ... later modification to StringIO#string might affect the line

resolves GH-5203
    @kares
    kares committed May 31, 2018
    Copy the full SHA
    b087544 View commit details
    Browse the repository at this point in the history