Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell infra: Allow overriding haskellSrc2nix #41331

Merged
merged 1 commit into from
May 31, 2018
Merged

haskell infra: Allow overriding haskellSrc2nix #41331

merged 1 commit into from
May 31, 2018
+1 −1

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #41330

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314
haskell infra: Allow overriding haskellSrc2nix

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan
GPG key ID: 69AC5BC354C89BE6
Verified
Learn about vigilant mode
58ce59d
@Ericson2314 Ericson2314 requested a review from peti as a code owner May 31, 2018 20:31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 31, 2018
@Ericson2314 Ericson2314 merged commit df1d6ac into NixOS:release-18.03 May 31, 2018
@Ericson2314 Ericson2314 deleted the haskellSrc2nix-overriding branch May 31, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg