Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-modules/configuration-ghc-8.4.x: bugfix - hoopl is still a core library #41333

Closed
wants to merge 1 commit into from
Closed

haskell-modules/configuration-ghc-8.4.x: bugfix - hoopl is still a core library #41333

wants to merge 1 commit into from

Conversation

jhenahan
Copy link
Contributor

Without this change, ghc84 won't build. The change is present in the 8.2.x config, but doesn't seem to have made it to 8.4.x. Trying to get nox working, so I can test more thoroughly.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jhenahan
configuration-ghc-8.4.x: bugfix
5165c68 
`hoopl` is still a core library. It looks like this just didn't get copied over from the 8.2.x config. This prevents ghc84 from building.
@jhenahan jhenahan requested a review from peti as a code owner May 31, 2018 20:34
@jhenahan jhenahan changed the title haskell-modules/configuration-ghc-8.2.x: bugfix - hoopl is still a core library haskell-modules/configuration-ghc-8.4.x: bugfix - hoopl is still a core library Jun 1, 2018
peti
peti requested changes Jun 3, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ nix-shell --run "ghc-pkg list hoopl" -p haskell.compiler.ghc843
/nix/store/alr3m7ya6qi0yr1zscs6fyxh14d0mda3-ghc-8.4.3/lib/ghc-8.4.3/package.conf.d
    (no packages)

It doesn't look like a core library to me.

@jhenahan jhenahan closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhenahan @peti @GrahamcOfBorg @Janik-Haag