Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration-ghc-8.4.x: bump to dhall_1_14_0 #41334

Merged
merged 1 commit into from Jun 3, 2018
Merged

configuration-ghc-8.4.x: bump to dhall_1_14_0 #41334

merged 1 commit into from Jun 3, 2018

Conversation

jhenahan
Copy link
Contributor

Motivation for this change

The dhall_1_13_0 attribute doesn't exist, anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Additionally, what's the process for library versions becoming the default? For this instance, what's preventing dhall just pointing at 1.14.0, rather than using a versioned attribute?

@jhenahan
configuration-ghc-8.4.x: bump to dhall_1_14_0
286f9ca 
The `dhall_1_13_0` attribute doesn't exist, anymore.
@jhenahan jhenahan requested a review from peti as a code owner May 31, 2018 20:40
@peti
Copy link
Member

peti commented Jun 3, 2018

Additionally, what's the process for library versions becoming the default?

We distribute the latest LTS Haskell version by default. See https://www.stackage.org/ for further details.

@peti
Copy link
Member

peti commented Jun 3, 2018

@GrahamcOfBorg build haskell.packages.ghc843.dhall

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskell.packages.ghc843.dhall

Partial log (click to expand)

strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zlb1cq1ck7484rlm6skavjs46grvsplj-dhall-1.14.0/lib  /nix/store/zlb1cq1ck7484rlm6skavjs46grvsplj-dhall-1.14.0/bin
patching script interpreter paths in /nix/store/zlb1cq1ck7484rlm6skavjs46grvsplj-dhall-1.14.0
checking for references to /build in /nix/store/zlb1cq1ck7484rlm6skavjs46grvsplj-dhall-1.14.0...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/9nv6xkip4hb59y248lr00avphiixis4y-dhall-1.14.0-doc
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9nv6xkip4hb59y248lr00avphiixis4y-dhall-1.14.0-doc
checking for references to /build in /nix/store/9nv6xkip4hb59y248lr00avphiixis4y-dhall-1.14.0-doc...
/nix/store/zlb1cq1ck7484rlm6skavjs46grvsplj-dhall-1.14.0

@peti peti merged commit da11a27 into NixOS:master Jun 3, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskell.packages.ghc843.dhall

Partial log (click to expand)

cannot build derivation '/nix/store/3x7saf4khiagza1akx5jga7qwy8krf4m-x509-system-1.6.6.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/l6mxpfjc98d07zc9lgaddyfaygxkvn53-x509-validation-1.6.10.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/81x2w4bn8vk7qq0s0pii4zv15q7xbwph-kan-extensions-5.1.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/s23hrwa6w9skpmiv8i1q6ixin7is76bw-tls-1.4.1.drv': 17 dependencies couldn't be built
cannot build derivation '/nix/store/yy1f3qdamc8yipnczxzih2zvazn1y9az-connection-0.2.8.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/ld0bgxmaaq2f7c535d68wacw9nap44m6-lens-4.16.1.drv': 34 dependencies couldn't be built
cannot build derivation '/nix/store/nsriqbv9yvj7zqzrf8v9cvqgj6xs1xbh-http-client-tls-0.3.5.3.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/j70k0yyslrdijbr7q4gw4cp1nbqm4gs6-insert-ordered-containers-0.2.1.0.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/8n1lmv9f86sl63sihdfywq7673j6w3fv-dhall-1.14.0.drv': 25 dependencies couldn't be built
error: build of '/nix/store/8n1lmv9f86sl63sihdfywq7673j6w3fv-dhall-1.14.0.drv' failed

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.packages.ghc843.dhall

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhenahan @peti @GrahamcOfBorg