Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godep: remove in favor of dep #41350

Merged
merged 1 commit into from Jun 3, 2018
Merged

godep: remove in favor of dep #41350

merged 1 commit into from Jun 3, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 1, 2018

upstream deprecated this and recommend dep

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
godep: remove in favor of dep
5feb8d3 
upstream deprecated this and recommend dep
@Mic92
Copy link
Member Author

Mic92 commented Jun 1, 2018

stop me if it is still useful: @offline

@Mic92 Mic92 merged commit b240ab1 into NixOS:master Jun 3, 2018
@Mic92 Mic92 deleted the godep branch June 3, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg