Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "itstool: 2.0.2 -> 2.0.4" #41339

Merged
merged 1 commit into from Jun 1, 2018
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 31, 2018

Reverts #37028

There is an upstream bug itstool/itstool#17, breaking gnome, gnumeric and others.

cc @matthewbauer @ryantm

@grahamc
Copy link
Member

grahamc commented Jun 1, 2018

@GrahamcOfBorg eval

@@ -2,11 +2,11 @@
# We need the same Python as is used to build libxml2Python

stdenv.mkDerivation rec {
name = "itstool-2.0.4";
name = "itstool-2.0.2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that 2.0.4 is broken linking to the upstream issue, so that we do not accidentally update again.

@orivej
Copy link
Contributor

orivej commented Jun 1, 2018

I have also checked that 2.0.3 hangs while processing gnome3.gnome-devel-docs, probably due to itstool/itstool#15, so we should stay with 2.0.2.

@jtojnar jtojnar force-pushed the revert-37028-auto-update/itstool branch from 4ebf21c to 2bfa0f9 Compare June 1, 2018 08:44
@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 1, 2018

Comment added. Should this go to staging, though? It is blocking a channel bump (via gnome3).

@orivej orivej merged commit fd9cfc4 into staging Jun 1, 2018
@orivej
Copy link
Contributor

orivej commented Jun 1, 2018

Yes, the current iteration of staging is used to stabilize master, it accumulates mass rebuilds that should be merged soon.

@jtojnar jtojnar deleted the revert-37028-auto-update/itstool branch June 1, 2018 15:27
@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 1, 2018

The issue is, #37028 already got to master and is breaking it.

@orivej
Copy link
Contributor

orivej commented Jun 1, 2018

Yes, but there are other breakages in master that require a mass rebuild, with fixes in staging: ef69523, 0248717, c83a530.

@jtojnar jtojnar mentioned this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants