restic: add s3CredentialsFile option #41343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 1, 2018
|
|
||
| s3CredentialsFile = mkOption { | ||
| type = types.str; |
There was a problem hiding this comment.
I suppose it should have a default value:
type = with types; nullOr str;
default = null;
| @@ -134,6 +142,8 @@ with lib; | |||
| Type = "oneshot"; | |||
| ExecStart = "${resticCmd} backup ${concatStringsSep " " backup.extraBackupArgs} ${concatStringsSep " " backup.paths}"; | |||
| User = backup.user; | |||
| } // optionalAttrs (backup.s3CredentialsFile != "") { | |||
There was a problem hiding this comment.
With the new default it can be compared with null instead of empty string.
|
fixed to use |
|
Hm ... am I missing a |
9 tasks
|
yep, I am -- sorry! fixed in #44332. |
|
Why do you call this |
|
was just too focused on that use case -- okay w/ me if you want to rename it. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)