Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep2nix: init at 0.0.1 #41352

Merged
merged 1 commit into from Jun 1, 2018
Merged

dep2nix: init at 0.0.1 #41352

merged 1 commit into from Jun 1, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 1, 2018 •
edited

Motivation for this change

cc @qknight

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
checking for references to /build in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1...
/nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dep2nix

Partial log (click to expand)

installing
/private/tmp/nix-build-dep2nix-0.0.1.drv-0/go /private/tmp/nix-build-dep2nix-0.0.1.drv-0
/private/tmp/nix-build-dep2nix-0.0.1.drv-0
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/i2ld2sx1m1cvnndzf6gxz7g7a789ba9n-dep2nix-0.0.1
/nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1
checking for references to /build in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1...
/nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin

gebner
gebner reviewed Jun 1, 2018
View reviewed changes
pkgs/development/tools/dep2nix/default.nix Outdated
meta = with stdenv.lib; {
description = "Convert `Gopkg.lock` files from golang dep into `deps.nix`";
license = licenses.bsd3;
homepage = https://github.com/nixcloud.io/dep2nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a 404 for this URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

/nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dep2nix

Partial log (click to expand)

/nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
checking for references to /build in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1...
/nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1
checking for references to /build in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1...
/nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dep2nix

Partial log (click to expand)

installing
/private/tmp/nix-build-dep2nix-0.0.1.drv-0/go /private/tmp/nix-build-dep2nix-0.0.1.drv-0
/private/tmp/nix-build-dep2nix-0.0.1.drv-0
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/xgrs8r61ccqx33d4fy8fdxcdwwrx872a-dep2nix-0.0.1
/nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1
checking for references to /build in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1...
/nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin

orivej
orivej reviewed Jun 1, 2018
View reviewed changes
pkgs/development/tools/dep2nix/default.nix Outdated
name = "dep2nix-${version}";
version = "0.0.1";

goPackagePath = "github.com/nixcloud.io/dep2nix";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed upstream: nixcloud/dep2nix#11

Mic92 added a commit to Mic92/dep2nix that referenced this pull request Jun 1, 2018
@Mic92
default.nix: correct go package path
bd5cbcf 
NixOS/nixpkgs#41352 (comment)
@Mic92 Mic92 mentioned this pull request Jun 1, 2018
Merged
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/lhn29ak39xz1f92j85d8l7hacyxqb2gn-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lhn29ak39xz1f92j85d8l7hacyxqb2gn-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/lhn29ak39xz1f92j85d8l7hacyxqb2gn-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/lhn29ak39xz1f92j85d8l7hacyxqb2gn-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/vhnp2hasflxvv0iqparhvsrz37cr9qjv-dep2nix-0.0.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vhnp2hasflxvv0iqparhvsrz37cr9qjv-dep2nix-0.0.1
checking for references to /build in /nix/store/vhnp2hasflxvv0iqparhvsrz37cr9qjv-dep2nix-0.0.1...
/nix/store/lhn29ak39xz1f92j85d8l7hacyxqb2gn-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dep2nix

Partial log (click to expand)

shrinking /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1
checking for references to /build in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1...
/nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: dep2nix

Partial log (click to expand)

    + set -o pipefail
    ++ nix eval '(builtins.anotherNull)' --option setting-set true --option plugin-files /private/tmp/nix-build-nix-2.0.4.drv-0/nix-2.0.4/tests/plugins/libplugintest.dylib
    error: opening lock file '/private/tmp/nix-test/var/nix/db/big-lock': Permission denied
    + res=
48 out of 51 tests failed
make: *** [mk/tests.mk:12: installcheck] Error 1
builder for '/nix/store/hbv0sai8kdsv4rc009jd3jypzqpblyap-nix-2.0.4.drv' failed with exit code 2
cannot build derivation '/nix/store/y89wiz0ykdp6hcvg7b0ppp04cbwh93ls-nix-prefetch-git.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/72np7kwgv2yganm97ccb1ac6nsam3jb5-dep2nix-0.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/72np7kwgv2yganm97ccb1ac6nsam3jb5-dep2nix-0.0.1.drv' failed

@xeji xeji merged commit 85a7b75 into NixOS:master Jun 1, 2018
@Mic92 Mic92 deleted the dep2nix branch September 6, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

@gebner gebner gebner left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @GrahamcOfBorg @orivej @gebner @xeji