Add specs for Time parser to raise when time zone is missing #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Jun 11, 2018
src/time/format.cr
Outdated
| @@ -30,12 +30,12 @@ require "./format/parser" | |||
| # * **%j**: day of year, zero padded (001, 002, ..., 365) | |||
| # * **%k**: hour of the day, 24-hour clock, blank padded (" 0", " 1", ..., "24") | |||
| # * **%l**: hour of the day, 12-hour clock, blank padded (" 0", " 1", ..., "12") | |||
| # * **%L**: milliseconds, zero padded (000, 001, ..., 999) | |||
| # * **%L**: milliseconds, zero padded (000, 001, ..., 999) (also **%3N**) | |||
straight-shoota
force-pushed
the
jm/feature/time-format-emtpy-zone-spec
branch
from
8a5ef30
to
a09c579
Compare
straight-shoota
force-pushed
the
jm/feature/time-format-emtpy-zone-spec
branch
from
a09c579
to
dadc109
Compare
sdogruyol
approved these changes
Jun 15, 2018
|
Thanks @straight-shoota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surpasses #5382