Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom: patchelf ctags binary #41811

Merged
merged 1 commit into from Jun 10, 2018
Merged

atom: patchelf ctags binary #41811

merged 1 commit into from Jun 10, 2018

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

The fix (introduced by #16056) got removed and the issue #15528 can be reproduced.

This adds the fix back in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build atom

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom

Partial log (click to expand)

/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/resources/app/apm/node_modules/node-gyp/gyp/gyp: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/bin/.atom-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2...
cannot find section .dynamic
file /nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/atom had a PT_GNU_STACK program header, converted
file /nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2/share/atom/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/qv6pncykspnsg4vprdln85p8cc678sz2-atom-1.27.2

@xeji xeji merged commit 8d48824 into NixOS:master Jun 10, 2018
@Gerschtli Gerschtli deleted the fix/atom branch June 12, 2018 12:42
@Synthetica9 Synthetica9 mentioned this pull request Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @xeji @GrahamcOfBorg