Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb galera: fix build #41813

Merged
merged 1 commit into from Jun 11, 2018
Merged

mariadb galera: fix build #41813

merged 1 commit into from Jun 11, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 10, 2018 •
edited

Motivation for this change

Plugins mariadb galero error build with asio 1.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin force-pushed the mariadb-galera-fix branch 2 times, most recently from ea6acae to dd3324e Compare June 11, 2018 08:04
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 11, 2018

Need this PR asio 1.10.8 #41822

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

@GrahamcOfBorg eval

@Izorkin Izorkin mentioned this pull request Jun 11, 2018
Merged
8 tasks
xeji
xeji approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfree mariadb-galera builds on my local machine.
No effect on mariadb (0 rebuilds)

@xeji xeji merged commit 1705428 into NixOS:master Jun 11, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 11, 2018

Thanks

@Izorkin Izorkin deleted the mariadb-galera-fix branch June 11, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @xeji @GrahamcOfBorg