Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asio: add old version 1.10.8 #41822

Merged
merged 1 commit into from Jun 11, 2018
Merged

asio: add old version 1.10.8 #41822

merged 1 commit into from Jun 11, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 11, 2018 •
edited

Motivation for this change

Asio v1.10.8 need to build MariaDB Galera plugins

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin mentioned this pull request Jun 11, 2018
Merged
8 tasks
veprbl
veprbl reviewed Jun 11, 2018
View reviewed changes
pkgs/development/libraries/asio/generic.nix
@@ -0,0 +1,25 @@
{stdenv, fetchurl, boost, openssl
, version, sha256, ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need triple dots here?

Copy link
Contributor Author

@Izorkin Izorkin Jun 11, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not work without triple dots

nix build -f /home/test/src_nix/nixpkgs_my asio_1_10                                                                                                                     
error: anonymous function at /home/test/src_nix/nixpkgs_my/pkgs/development/libraries/asio/generic.nix:1:1 called with unexpected argument 'callPackage', at /home/test/src_nix/nixpkgs_my/lib/customisation.nix:74:12

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

@GrahamcOfBorg build asio_1_10 asio_1_12

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: asio_1_10, asio_1_12

Partial log (click to expand)

make[1]: Entering directory '/private/tmp/nix-build-asio-1.10.8.drv-0/asio-1.10.8'
make[2]: Entering directory '/private/tmp/nix-build-asio-1.10.8.drv-0/asio-1.10.8'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-asio-1.10.8.drv-0/asio-1.10.8'
make[1]: Leaving directory '/private/tmp/nix-build-asio-1.10.8.drv-0/asio-1.10.8'
post-installation fixup
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/w77x56zykapg5yddp4mvcqmgxn9qwjh2-asio-1.10.8
error: build of '/nix/store/9h7i6v0mza9ikq5hk699b3cs9fy3j6yz-asio-1.12.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: asio_1_10, asio_1_12

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/build/asio-1.10.8'
make[1]: Leaving directory '/build/asio-1.10.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mrhnhrjhc9h9swxpm40gmb9pzz6ix7h0-asio-1.10.8
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mrhnhrjhc9h9swxpm40gmb9pzz6ix7h0-asio-1.10.8
checking for references to /build in /nix/store/mrhnhrjhc9h9swxpm40gmb9pzz6ix7h0-asio-1.10.8...
/nix/store/mrhnhrjhc9h9swxpm40gmb9pzz6ix7h0-asio-1.10.8
/nix/store/8qhkrv2cnxkc8ydjcbx5a402z3wsxb1f-asio-1.12.1

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 11, 2018

@xeji need change to linux only?

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

No, previous versions built on Darwin: https://hydra.nixos.org/job/nixpkgs/trunk/asio.x86_64-darwin
but have failed since 1.12.1. Not related to this PR.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: asio_1_10, asio_1_12

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/build/asio-1.10.8'
make[1]: Leaving directory '/build/asio-1.10.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l4j47lgcqwmqbjl57y7v9hhvav0siif7-asio-1.10.8
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/l4j47lgcqwmqbjl57y7v9hhvav0siif7-asio-1.10.8
checking for references to /build in /nix/store/l4j47lgcqwmqbjl57y7v9hhvav0siif7-asio-1.10.8...
/nix/store/l4j47lgcqwmqbjl57y7v9hhvav0siif7-asio-1.10.8
/nix/store/90342vk7cmsv176pp3am4p8hrbynckk3-asio-1.12.1

@xeji xeji merged commit 2f73a37 into NixOS:master Jun 11, 2018
@Izorkin Izorkin mentioned this pull request Jun 11, 2018
Merged
8 tasks
@Izorkin Izorkin deleted the asio_1_10 branch June 11, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @xeji @GrahamcOfBorg @veprbl