Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meguca: 2018-05-26 -> 2018-06-11 #41823

Merged
merged 14 commits into from Jul 2, 2018
Merged

meguca: 2018-05-26 -> 2018-06-11 #41823

merged 14 commits into from Jul 2, 2018

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jun 11, 2018

Motivation for this change

Update meguca, nodePackages: meguca, and easyjson.
Fix password being shown by top.
Fix database permission issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Chiiruno
Copy link
Contributor Author

Don't pull yet please, I have to fiddle with the node package a little.

@Chiiruno
Copy link
Contributor Author

Ok, ready for merging again.

@Chiiruno Chiiruno changed the title meguca: 2018-05-26 -> 2018-06-10 meguca: 2018-05-26 -> 2018-06-11 Jun 11, 2018
@lukateras
Copy link
Member

@GrahamcOfBorg build meguca

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: meguca

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: meguca

Partial log (click to expand)

find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
find: '/nix/store/49jry6xkg2v4srajbmv22labrca57p9i-meguca-unstable-2018-06-11': No such file or directory
/nix/store/in020k7vj3mlvwrhrfvymxd8s5jfk4y5-meguca-unstable-2018-06-11-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: meguca

Partial log (click to expand)

/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/json5/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/user-home/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/typescript/bin/tsserver: interpreter directive changed from "/usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/typescript/bin/tsc: interpreter directive changed from "/usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/gulp-uglify/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
/nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7/lib/node_modules/meguca/node_modules/atob/bin/atob.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/s4ifl8s2jj1nqkssl5lfx8qhx9d6zam8-nodejs-6.14.2/bin/node"
checking for references to /build in /nix/store/n1vfdkn2fw8sm9sb1jis9jpwlpicwfvd-node-meguca-1.0.7...
cannot build derivation '/nix/store/f6qav3znhab37fyjzc24bjazl0fwncwf-meguca-unstable-2018-06-11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f6qav3znhab37fyjzc24bjazl0fwncwf-meguca-unstable-2018-06-11.drv' failed

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jun 16, 2018

Did it time out on x86_64-linux?
That should have compiled.

@Chiiruno
Copy link
Contributor Author

I guess don't merge in the meantime, I'm going to submit another commit within ~4 days.

@Chiiruno
Copy link
Contributor Author

@yegortimoshenko Should be ready for building and merging again.
I hope you don't mind the ping.

@Chiiruno
Copy link
Contributor Author

@Mic92
Copy link
Member

Mic92 commented Jun 27, 2018

@GrahamcOfBorg build meguca

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: meguca

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: meguca

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin
shrinking /nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin/bin/meguca
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin/bin
patching script interpreter paths in /nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin
checking for references to /build in /nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin...
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
/nix/store/99rbsvxrws3cgxizb9pjndxnibvv8npg-meguca-unstable-2018-06-23-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: meguca

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-meguca-unstable-2018-06-23.drv-0/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:34: wasm] Error 2
error: unable to open output file '/tmp/tmpvwfE_z/cxa_default_handlers.cpp.o': 'No such file or directory'
1 error generated.
ERROR:root:compiler frontend failed to generate LLVM bitcode, halting
error: unable to open output file '/tmp/tmpvwfE_z/cxa_demangle.cpp.o': 'No such file or directory'
1 error generated.
ERROR:root:compiler frontend failed to generate LLVM bitcode, halting
builder for '/nix/store/r25n8ssl1yvdkwlz8cj8gk1i490r9257-meguca-unstable-2018-06-23.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/r25n8ssl1yvdkwlz8cj8gk1i490r9257-meguca-unstable-2018-06-23.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jun 27, 2018

Did macOS worked before?

@Chiiruno
Copy link
Contributor Author

@Mic92 Yes, however I think the problem may be that I have to add in libcxx for Darwin now, for some reason.

@Mic92
Copy link
Member

Mic92 commented Jul 2, 2018

@GrahamcOfBorg build meguca

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: meguca

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: meguca

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin
shrinking /nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin/bin/meguca
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin/bin
patching script interpreter paths in /nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin
checking for references to /build in /nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin...
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
/nix/store/xvb6r982q621drnn5mn6ycig7ig9d4lf-meguca-unstable-2018-07-01-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: meguca

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-meguca-unstable-2018-07-01.drv-0/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:34: wasm] Error 2
error: unable to open output file '/tmp/tmplC4z4U/cxa_default_handlers.cpp.o': 'No such file or directory'
1 error generated.
ERROR:root:compiler frontend failed to generate LLVM bitcode, halting
error: unable to open output file '/tmp/tmplC4z4U/cxa_demangle.cpp.o': 'No such file or directory'
1 error generated.
ERROR:root:compiler frontend failed to generate LLVM bitcode, halting
builder for '/nix/store/sj8wkpw2kg9w0zhibyfrilcs9192995s-meguca-unstable-2018-07-01.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/sj8wkpw2kg9w0zhibyfrilcs9192995s-meguca-unstable-2018-07-01.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jul 2, 2018

I think it would be acceptable to disable macOS for the time being until we have a real macOS maintainer for that package.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jul 2, 2018

I'll just disable building the C++ client for Darwin, maybe upstream hasn't tested this emscripten code with MacOS.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jul 2, 2018

@Mic92 Should be ready for building and merging.

@Mic92
Copy link
Member

Mic92 commented Jul 2, 2018

@GrahamcOfBorg build meguca

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: meguca

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: meguca

Partial log (click to expand)

find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
find: '/nix/store/6wybhr91i776x1y7z6bfyjpwk02xr3hv-meguca-unstable-2018-07-01': No such file or directory
/nix/store/d5gxzvpiq47a7fk7frxccyk14a5x04y1-meguca-unstable-2018-07-01-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: meguca

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin
shrinking /nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin/bin/meguca
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin/bin
patching script interpreter paths in /nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin
checking for references to /build in /nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin...
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
/nix/store/h0l4899mffhra70v45zwp1rsf6zm8dif-meguca-unstable-2018-07-01-bin

@Mic92
Copy link
Member

Mic92 commented Jul 2, 2018

Does the packages has any use, if those components are not build on macOS? I would rather ship no packages then a useless one.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jul 2, 2018

The C++ client is kind of a developing feature anyway, I only included it since it was easy enough to include, and will eventually replace the Javascript client.
Everything will work without it.

@Mic92 Mic92 merged commit 8cf4a47 into NixOS:master Jul 2, 2018
@Chiiruno Chiiruno deleted the dev/meguca branch July 2, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants