New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meguca: 2018-05-26 -> 2018-06-11 #41823
Conversation
Don't pull yet please, I have to fiddle with the node package a little. |
Ok, ready for merging again. |
@GrahamcOfBorg build meguca |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: meguca Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: meguca Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: meguca Partial log (click to expand)
|
Did it time out on x86_64-linux? |
I guess don't merge in the meantime, I'm going to submit another commit within ~4 days. |
@yegortimoshenko Should be ready for building and merging again. |
@GrahamcOfBorg build meguca |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: meguca Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: meguca Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: meguca Partial log (click to expand)
|
Did macOS worked before? |
@Mic92 Yes, however I think the problem may be that I have to add in |
@GrahamcOfBorg build meguca |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: meguca Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: meguca Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: meguca Partial log (click to expand)
|
I think it would be acceptable to disable macOS for the time being until we have a real macOS maintainer for that package. |
I'll just disable building the C++ client for Darwin, maybe upstream hasn't tested this emscripten code with MacOS. |
@Mic92 Should be ready for building and merging. |
@GrahamcOfBorg build meguca |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: meguca Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: meguca Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: meguca Partial log (click to expand)
|
Does the packages has any use, if those components are not build on macOS? I would rather ship no packages then a useless one. |
The C++ client is kind of a developing feature anyway, I only included it since it was easy enough to include, and will eventually replace the Javascript client. |
Motivation for this change
Update meguca, nodePackages: meguca, and easyjson.
Fix password being shown by top.
Fix database permission issue.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)