GCE image: properly remove the temporary ssh host keys files/directory #41311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the temporary ssh host keys file/directory.
xeji
reviewed
Jun 3, 2018
| @@ -253,11 +253,12 @@ in | |||
| mv -f $SSH_HOST_KEYS_DIR/ssh_host_ed25519_key* /etc/ssh/ | |||
| chmod 600 /etc/ssh/ssh_host_ed25519_key | |||
| chmod 644 /etc/ssh/ssh_host_ed25519_key.pub | |||
| rm $SSH_HOST_KEYS_DIR/* | |||
There was a problem hiding this comment.
This line looks redundant since you rm -r $SSH_HOST_KEYS_DIR below anyway.
| else | ||
| echo "Setup of ssh host keys from http://metadata.google.internal/computeMetadata/v1/instance/attributes/ failed." | ||
| false | ||
| fi | ||
| rm -f $SSH_HOST_KEYS_DIR | ||
| rm -r $SSH_HOST_KEYS_DIR |
There was a problem hiding this comment.
let's make this rm -rf to prevent error messages and prompts.
There was a problem hiding this comment.
@xeji yeah I kinda try avoiding rm -rf's in general in case something unexpected happens but this should be fine so I'll change it. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)