lz4: 131 -> 1.8.2 #41293

bhipple · 2018-05-31T01:14:13Z

Upgrades lz4 from version 131 (released 2015-06-29) to v1.8.2 (released 2018-05-07).

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-05-31T01:26:37Z

Success on x86_64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2/lib  /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2/bin
patching script interpreter paths in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2
checking for references to /build in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev/lib
patching script interpreter paths in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev
checking for references to /build in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev...
/nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2

GrahamcOfBorg · 2018-05-31T01:27:07Z

Success on aarch64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2/lib  /nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2/bin
patching script interpreter paths in /nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2
checking for references to /build in /nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/4qc9j7hlizpxvm95whqiszjh48ykz48x-lz4-1.8.2-dev
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qc9j7hlizpxvm95whqiszjh48ykz48x-lz4-1.8.2-dev/lib
patching script interpreter paths in /nix/store/4qc9j7hlizpxvm95whqiszjh48ykz48x-lz4-1.8.2-dev
checking for references to /build in /nix/store/4qc9j7hlizpxvm95whqiszjh48ykz48x-lz4-1.8.2-dev...
/nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2

bhipple · 2018-05-31T01:30:45Z

Hmm 501+ packages to rebuild. Let me know if I should rebase onto staging instead.

orivej · 2018-05-31T01:38:00Z

This is very likely to break some packages (in particular due to the changes in API). I think it should be approached like boost in #41258 (comment): wait for the current staging to complete and be merged to master, then merge this PR to staging. (A better workflow is under discussion at NixOS/rfcs#26 (comment).)

Upgrades lz4 from version 131 (released 2015-06-29) to v1.8.2 (released 2018-05-07)

bhipple · 2018-05-31T02:01:08Z

Ack, rebased my commit onto staging and changed the target branch. Letting this sit until we're ready is fine by me.

GrahamcOfBorg · 2018-05-31T02:12:51Z

Success on x86_64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2/lib  /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2/bin
patching script interpreter paths in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2
checking for references to /build in /nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev/lib
patching script interpreter paths in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev
checking for references to /build in /nix/store/h84aivnyj80k79n32hp2gll8w12qn11x-lz4-1.8.2-dev...
/nix/store/fwkl7icclcdy1579gl0ld157wcpp0byd-lz4-1.8.2

GrahamcOfBorg · 2018-05-31T02:12:58Z

Success on aarch64-linux (full log)

Attempted: lz4

Partial log (click to expand)

/nix/store/kr2m6s3ccp78r0ixawgky3kysm5zfh77-lz4-1.8.2

dtzWill · 2018-06-09T06:39:00Z

This seems to have broken spice-- which is critical because it's on the path to qemu. I'd link hydra but can't find it for whatever reason.

@GrahamcOfBorg build spice qemu

GrahamcOfBorg · 2018-06-09T06:43:26Z

Failure on x86_64-linux (full log)

Attempted: spice, qemu

Partial log (click to expand)

patching script interpreter paths in /nix/store/nz8kab018apf026m7jmcfidcqdkq43n1-SDL2-2.0.8
checking for references to /build in /nix/store/nz8kab018apf026m7jmcfidcqdkq43n1-SDL2-2.0.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev/lib  /nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev/bin
patching script interpreter paths in /nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev
/nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/ifzw9sgycp0qnh84jp5kqafpx0cnv4bq-SDL2-2.0.8-dev...
cannot build derivation '/nix/store/5wvd03x8h169iyvfv5s7dyhi3kak44nd-qemu-2.12.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5wvd03x8h169iyvfv5s7dyhi3kak44nd-qemu-2.12.0.drv', '/nix/store/r31p2ip5517fvc2101c7cjxh3qrcvhnm-spice-0.13.3.drv' failed

orivej · 2018-06-09T06:53:57Z

Yes, spice configure fails with:

configure:13873: $PKG_CONFIG --exists --print-errors "liblz4 >= 129"
Requested 'liblz4 >= 129' but version of lz4 is 1.8.2
You may find new versions of lz4 at http://www.lz4.org/

This is fixed in spice 0.14.0, I'm going to update it.

orivej · 2018-06-09T06:55:22Z

@dtzWill or would you like to reopen #37813?

dtzWill · 2018-06-09T06:55:26Z

FWIW: #37813 :)

Haha, I don't want to "own" it at the moment but happy to reopen or you can open your own using whatever parts of it you like :).

GrahamcOfBorg · 2018-06-09T07:21:53Z

Success on x86_64-darwin (full log)

Attempted: qemu

The following builds were skipped because they don't evaluate on x86_64-darwin: spice

Partial log (click to expand)

find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
find: '/nix/store/9glybq1g4yb9lkzw0h42hy554x0qsrbi-qemu-2.12.0-ga': No such file or directory
/nix/store/3cw4l9snv7qwll0m1hzhq3zfcg5l1nrv-qemu-2.12.0

GrahamcOfBorg · 2018-06-09T09:01:32Z

Failure on aarch64-linux (full log)

Attempted: spice, qemu

Partial log (click to expand)

rmdir: failed to remove '/nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2
shrinking /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2/bin/vte-2.91
shrinking /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2/lib/libvte-2.91.so.0.5200.2
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2/lib  /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2/bin
patching script interpreter paths in /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2
checking for references to /build in /nix/store/a8cn5r3c8rvlal6q3m7n3yhyczysbhgp-vte-0.52.2...
cannot build derivation '/nix/store/blz5p68q28wxivc2q2cmbnb8p2rigzvh-qemu-2.12.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/blz5p68q28wxivc2q2cmbnb8p2rigzvh-qemu-2.12.0.drv', '/nix/store/p1w3dkpqrcm4z3g2qmpwd2ixl4y311id-spice-0.13.3.drv' failed

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ labels May 31, 2018

orivej changed the title ~~lz4: 131 -> v1.8.2~~ lz4: 131 -> 1.8.2 May 31, 2018

bhipple changed the base branch from master to staging May 31, 2018 01:56

bhipple force-pushed the u/lz4 branch from d72338c to 725b801 Compare May 31, 2018 01:56

lz4: 131 -> v1.8.2

768df1f

Upgrades lz4 from version 131 (released 2015-06-29) to v1.8.2 (released 2018-05-07)

bhipple force-pushed the u/lz4 branch from 725b801 to 768df1f Compare May 31, 2018 01:57

GrahamcOfBorg added 6.topic: nixos 6.topic: policy discussion 6.topic: vim 8.has: documentation 8.has: module (update) labels May 31, 2018

GrahamcOfBorg added 8.has: clean-up 8.has: package (new) and removed 6.topic: nixos 6.topic: policy discussion 6.topic: vim 8.has: documentation 8.has: module (update) labels May 31, 2018

orivej merged commit 1baf5cf into NixOS:staging Jun 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lz4: 131 -> 1.8.2 #41293

lz4: 131 -> 1.8.2 #41293

bhipple commented May 31, 2018 •

edited

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

bhipple commented May 31, 2018

orivej commented May 31, 2018 •

edited

bhipple commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

dtzWill commented Jun 9, 2018

GrahamcOfBorg commented Jun 9, 2018

orivej commented Jun 9, 2018

orivej commented Jun 9, 2018

dtzWill commented Jun 9, 2018 •

edited

GrahamcOfBorg commented Jun 9, 2018

GrahamcOfBorg commented Jun 9, 2018

lz4: 131 -> 1.8.2 #41293

lz4: 131 -> 1.8.2 #41293

Conversation

bhipple commented May 31, 2018 • edited

Things done

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

bhipple commented May 31, 2018

orivej commented May 31, 2018 • edited

bhipple commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

dtzWill commented Jun 9, 2018

GrahamcOfBorg commented Jun 9, 2018

orivej commented Jun 9, 2018

orivej commented Jun 9, 2018

dtzWill commented Jun 9, 2018 • edited

GrahamcOfBorg commented Jun 9, 2018

GrahamcOfBorg commented Jun 9, 2018

bhipple commented May 31, 2018 •

edited

orivej commented May 31, 2018 •

edited

dtzWill commented Jun 9, 2018 •

edited