Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 66.0.3359.181 -> 67.0.3396.62 #41291

Merged
merged 6 commits into from May 31, 2018
Merged

chromium: 66.0.3359.181 -> 67.0.3396.62 #41291

merged 6 commits into from May 31, 2018

Conversation

YorikSar
Copy link
Contributor

Motivation for this change

Gathered fixes for Chromium 67 and bumped to newly released Stable version (67.0.3396.62).
Includes 34 security fixes, see blog post for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar
Copy link
Contributor Author

CC @bendlas @vcunat @7c6f434c

@YorikSar YorikSar changed the title Update chromium chromium: 66.0.3359.181 -> 67.0.3396.62 May 31, 2018
@7c6f434c
Copy link
Member

Is it intentional that plugin directory for NaCl doesn't fall back to general plugin directory?

(also — just for information — what CPUs does your «tested on NixOS» cover?)

@YorikSar
Copy link
Contributor Author

Is it intentional that plugin directory for NaCl doesn't fall back to general plugin directory?

I have no idea, I didn't touch the logic there.

(also — just for information — what CPUs does your «tested on NixOS» cover?)

Sadly only Intel amd64. I don't have means to run it on anything else right now.

@7c6f434c
Copy link
Member

Technically you could do an i686 build, but I know how frustrating Chromium builds are… I just wanted the situation about ARM stated explicitly in the conversation — given that there is an ARM-related change, if I understand the patch correct;y..

@7c6f434c 7c6f434c merged commit 5957fab into NixOS:master May 31, 2018
@YorikSar
Copy link
Contributor Author

@7c6f434c ftr, I verified that those ARM patches are applied upstream, so their limit to version <67 was right.

Could you please also merge this to stable branch? Or should I create PR there too?

@YorikSar
Copy link
Contributor Author

And one more thing. Here are new patches in upstream, we should switch to using githubPatch once they land:
https://chromium-review.googlesource.com/1079868 - openh264
https://chromium-review.googlesource.com/1079570 - font_service

7c6f434c added a commit that referenced this pull request May 31, 2018
@7c6f434c
Merge pull request #41291 from YorikSar/update-chromium
8f374ba 
chromium: 66.0.3359.181 -> 67.0.3396.62
(cherry picked from commit 5957fab)
@7c6f434c
Copy link
Member

Cherry-picked to 18.03 (I guess 17.09 is EOL by now?)

@vcunat
Copy link
Member

vcunat commented May 31, 2018

Thanks. Yes, 17.09 is EOL. That doesn't prevent anyone to maintain it, just that it isn't considered necessary, though absolutely critical security fixes might be good for a couple more months, if they appear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YorikSar @7c6f434c @vcunat @GrahamcOfBorg