Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove underscore and mark as private properties in meta #16700

Closed
wants to merge 1 commit into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented May 31, 2018

Is this good idea ?

@rwjblue
Copy link
Member

rwjblue commented Jun 17, 2018

Marking them as private is definitely good, however I’d still prefer to keep them underscored.

Being private only helps internal typescript consumers know not to touch these properties, but when Ember is consumed you would still be able to use them and now they would be without an underscore and seem “public”...

@bekzod
Copy link
Contributor Author

bekzod commented Jun 24, 2018

sounds fair closing

@bekzod bekzod closed this Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants