Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: grpcio: 1.9.1 -> 1.12.0 #41300

Merged
merged 1 commit into from Jun 17, 2018
Merged

python: grpcio: 1.9.1 -> 1.12.0 #41300

merged 1 commit into from Jun 17, 2018

Conversation

lopsided98
Copy link
Contributor

Updates grpcio to the latest version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 requested a review from FRidh as a code owner May 31, 2018 03:34
@lopsided98
Copy link
Contributor Author

cc @FRidh

@xeji
Copy link
Contributor

xeji commented Jun 1, 2018

@GrahamcOfBorg build python27Packages.grpcio python36Packages.grpcio

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python27Packages.grpcio, python36Packages.grpcio

Partial log (click to expand)

  File "/nix/store/30my13v47snx921qsfaxrlbmqn7hcakr-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/command/build_ext.py", line 78, in run
    _build_ext.run(self)
  File "/nix/store/vidjaj14dsiglsvghxrab1y74kad8d3l-python3-3.6.5/lib/python3.6/distutils/command/build_ext.py", line 339, in run
    self.build_extensions()
  File "/private/tmp/nix-build-python3.6-grpcio-1.12.0.drv-0/grpcio-1.12.0/src/python/grpcio/commands.py", line 278, in build_extensions
    raise Exception("make command failed!")
Exception: make command failed!
builder for '/nix/store/nirlrmdlhcqa68vhd170h4pcxlz1csqr-python2.7-grpcio-1.12.0.drv' failed with exit code 1
builder for '/nix/store/xvl1niqlx1al7f84a7jg68bahpnbylr5-python3.6-grpcio-1.12.0.drv' failed with exit code 1
error: build of '/nix/store/nirlrmdlhcqa68vhd170h4pcxlz1csqr-python2.7-grpcio-1.12.0.drv', '/nix/store/xvl1niqlx1al7f84a7jg68bahpnbylr5-python3.6-grpcio-1.12.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.grpcio, python36Packages.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-x86_64-3.6/grpc/_cython/cygrpc.cpython-36m-x86_64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/09ssh5j07cgx6c76v8nzrqdk7h6iy8r4-python2.7-grpcio-1.12.0
/nix/store/da2zjkpbx0kkggdc6md11gjagsgwni9v-python3.6-grpcio-1.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.grpcio, python36Packages.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-aarch64-3.6/grpc/_cython/cygrpc.cpython-36m-aarch64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/m6n57i7s3y3dqnds09anp2j2pnbzw6cr-python2.7-grpcio-1.12.0
/nix/store/d1274jp6x1ylaq44ana2xkdki1bsqhl5-python3.6-grpcio-1.12.0

@FRidh
Copy link
Member

FRidh commented Jun 1, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@orivej
Copy link
Contributor

orivej commented Jun 1, 2018

The current version is 1.9.1, not 1.9.0.

@lopsided98 lopsided98 changed the title python: grpcio: 1.9.0 -> 1.12.0 python: grpcio: 1.9.1 -> 1.12.0 Jun 1, 2018
@lopsided98
Copy link
Contributor Author

Grpc has tests, but they are not included in the package on PyPi. This has not changed since the previous version (see: https://hydra.nixos.org/build/74606746/nixlog/2/tail). I can disable the check phase, but I don't really see why that is necessary.

@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

It would be nicer to disable the tests but let's not hold the bump because of housekeeping.

@xeji xeji merged commit afbcc26 into NixOS:master Jun 17, 2018
@lopsided98 lopsided98 deleted the grpcio-update branch June 23, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lopsided98 @xeji @GrahamcOfBorg @FRidh @orivej