Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.amazon_kclpy: init at 1.5.0 #41310

Merged
merged 2 commits into from Jun 1, 2018
Merged

pythonPackages.amazon_kclpy: init at 1.5.0 #41310

merged 2 commits into from Jun 1, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner May 31, 2018 11:24
srhb
srhb requested changes May 31, 2018
View reviewed changes
pkgs/development/python-modules/amazon_kclpy/default.nix Outdated
meta = with stdenv.lib; {
description = "Amazon Kinesis Client Library for Python";
homepage = https://github.com/awslabs/amazon-kinesis-client-python;
license = licenses.asl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license does not exist.

@FRidh
Copy link
Member

FRidh commented May 31, 2018

@GrahamcOfBorg build pythonPackages.amazon_kclpy python3Packages.amazon_kclpy

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.amazon_kclpy, python3Packages.amazon_kclpy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.amazon_kclpy, python3Packages.amazon_kclpy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.amazon_kclpy, python3Packages.amazon_kclpy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@PsyanticY PsyanticY changed the title pythonPackage.amazon_kclpy: init at 1.5.0 pythonPackages.amazon_kclpy: init at 1.5.0 May 31, 2018
@PsyanticY
Copy link
Contributor Author

@FRidh Any idea how to deal with deal with GrahamcBorg skipping build cause of the un-free licence ?

@FRidh FRidh merged commit 104994f into NixOS:master Jun 1, 2018
@PsyanticY PsyanticY deleted the aws_kinesis branch June 4, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @FRidh @GrahamcOfBorg @srhb